From: Christoph Hellwig <hch@lst.de>
To: Song Liu <song@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Yu Kuai <yukuai3@huawei.com>,
linux-raid@vger.kernel.org
Subject: Re: fix ->run failure handling
Date: Tue, 11 Jun 2024 08:13:20 +0200 [thread overview]
Message-ID: <20240611061320.GA4744@lst.de> (raw)
In-Reply-To: <CAPhsuW7cBhbH9iQQunmVohGkwnGJNnw7PFfExXh3umL1qB=SVw@mail.gmail.com>
On Mon, Jun 10, 2024 at 01:58:17PM -0700, Song Liu wrote:
> > raid10 and raid5 also free conf on failure in their ->run handle,
> > but set mddev->private to NULL which prevents the double free as well
> > (but requires more code)
> >
> > Diffstat:
> > raid0.c | 21 +++++----------------
> > raid1.c | 14 +++-----------
> > 2 files changed, 8 insertions(+), 27 deletions(-)
>
> Thanks for the patchset. I applied it to the md-6.11 branch.
I was planning to respin this to also handle failures in the takeover
path.
next prev parent reply other threads:[~2024-06-11 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 17:25 fix ->run failure handling Christoph Hellwig
2024-06-04 17:25 ` [PATCH 1/2] md/raid0: don't free conf on raid0_run failure Christoph Hellwig
2024-06-07 6:08 ` Yu Kuai
2024-06-07 6:17 ` Yu Kuai
2024-06-07 6:19 ` Christoph Hellwig
2024-06-04 17:25 ` [PATCH 2/2] md/raid1: " Christoph Hellwig
2024-06-10 20:58 ` fix ->run failure handling Song Liu
2024-06-11 6:13 ` Christoph Hellwig [this message]
2024-06-12 16:36 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611061320.GA4744@lst.de \
--to=hch@lst.de \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).