From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai3@huawei.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org
Subject: move integrity settings to queue_limits v3
Date: Thu, 13 Jun 2024 10:48:10 +0200 [thread overview]
Message-ID: <20240613084839.1044015-1-hch@lst.de> (raw)
Hi Jens, hi Martin,
this series converts the blk-integrity settings to sit in the queue
limits and be updated through the atomic queue limits API.
I've mostly tested this with nvme, scsi is only covered by simple
scsi_debug based tests.
For MD I found an pre-existing error handling bug when combining PI
capable devices with not PI capable devices. The fix was posted here
(and is included in the git branch below):
https://lore.kernel.org/linux-raid/20240604172607.3185916-1-hch@lst.de/
For dm-integrity my testing showed that even the baseline fails to create
the luks-based dm-crypto with dm-integrity backing for the authentication
data. As the failure is non-fatal I've not addressed it here.
Note that the support for native metadata in dm-crypt by Mikulas will
need a rebase on top of this, but as it already requires another
block layer patch and the changes in this series will simplify it a bit
I hope that is ok.
The series is based on top of my previously sent "convert the SCSI ULDs
to the atomic queue limits API v2" API.
A git tree is available here:
git://git.infradead.org/users/hch/block.git block-integrity-limits
Gitweb:
http://git.infradead.org/?p=users/hch/block.git;a=shortlog;h=refs/heads/block-integrity-limits
Changes since v2:
- keep the unused BIP_CTRL_NOCHECK, BIP_DISK_NOCHECK and
BIP_IP_CHECKSUM flags for now
Changes since v1:
- keep generating (empty) non-PI metadata
- use a packed enum for the csum type
- remove an unused flag left in the code
Diffstat:
Documentation/block/data-integrity.rst | 49 ------
block/Kconfig | 8 -
block/Makefile | 3
block/bio-integrity.c | 43 +++--
block/blk-integrity.c | 229 ++++++++----------------------
block/blk-mq.c | 13 -
block/blk-settings.c | 118 ++++++++++++++-
block/blk.h | 8 +
block/t10-pi.c | 249 +++++++++++----------------------
drivers/md/dm-core.h | 1
drivers/md/dm-crypt.c | 4
drivers/md/dm-integrity.c | 47 +-----
drivers/md/dm-table.c | 161 +++------------------
drivers/md/md.c | 72 ++-------
drivers/md/md.h | 5
drivers/md/raid0.c | 28 +--
drivers/md/raid1.c | 24 +--
drivers/md/raid10.c | 10 -
drivers/md/raid5.c | 2
drivers/nvdimm/btt.c | 13 -
drivers/nvme/host/Kconfig | 1
drivers/nvme/host/core.c | 71 ++++-----
drivers/nvme/host/multipath.c | 3
drivers/nvme/target/Kconfig | 1
drivers/nvme/target/io-cmd-bdev.c | 16 +-
drivers/scsi/Kconfig | 1
drivers/scsi/sd.c | 8 -
drivers/scsi/sd.h | 12 -
drivers/scsi/sd_dif.c | 45 ++---
drivers/target/target_core_iblock.c | 49 +++---
include/linux/blk-integrity.h | 62 ++------
include/linux/blkdev.h | 25 ++-
include/linux/t10-pi.h | 20 --
33 files changed, 533 insertions(+), 868 deletions(-)
next reply other threads:[~2024-06-13 8:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 8:48 Christoph Hellwig [this message]
2024-06-13 8:48 ` [PATCH 01/12] block: initialize integrity buffer to zero before writing it to media Christoph Hellwig
2024-06-14 2:02 ` Martin K. Petersen
2024-06-14 12:45 ` Kanchan Joshi
2024-06-13 8:48 ` [PATCH 02/12] md/raid0: don't free conf on raid0_run failure Christoph Hellwig
2024-06-14 2:03 ` Martin K. Petersen
2024-06-13 8:48 ` [PATCH 03/12] md/raid1: " Christoph Hellwig
2024-06-14 2:04 ` Martin K. Petersen
2024-06-13 8:48 ` [PATCH 04/12] dm-integrity: use the nop integrity profile Christoph Hellwig
2024-06-14 2:04 ` Martin K. Petersen
2024-06-13 8:48 ` [PATCH 05/12] block: remove the blk_integrity_profile structure Christoph Hellwig
2024-06-14 2:11 ` Martin K. Petersen
2024-06-13 8:48 ` [PATCH 06/12] block: remove the blk_flush_integrity call in blk_integrity_unregister Christoph Hellwig
2024-06-13 8:48 ` [PATCH 07/12] block: factor out flag_{store,show} helper for integrity Christoph Hellwig
2024-06-13 8:48 ` [PATCH 08/12] block: use kstrtoul in flag_store Christoph Hellwig
2024-06-14 12:46 ` Kanchan Joshi
2024-06-13 8:48 ` [PATCH 09/12] block: don't require stable pages for non-PI metadata Christoph Hellwig
2024-06-13 8:48 ` [PATCH 10/12] block: bypass the STABLE_WRITES flag for protection information Christoph Hellwig
2024-06-13 8:48 ` [PATCH 11/12] block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags Christoph Hellwig
2024-06-14 2:11 ` Martin K. Petersen
2024-06-13 8:48 ` [PATCH 12/12] block: move integrity information into queue_limits Christoph Hellwig
2024-06-13 13:40 ` Hannes Reinecke
2024-06-14 2:18 ` Martin K. Petersen
2024-06-14 12:33 ` move integrity settings to queue_limits v3 Jens Axboe
2024-06-14 16:03 ` Christoph Hellwig
2024-06-14 16:04 ` Jens Axboe
2024-06-14 16:07 ` Christoph Hellwig
2024-06-14 16:16 ` Jens Axboe
2024-06-14 16:23 ` Jens Axboe
2024-06-15 5:01 ` Christoph Hellwig
2024-06-14 16:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613084839.1044015-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dm-devel@lists.linux.dev \
--cc=ira.weiny@intel.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).