From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-raid@vger.kernel.org, Jes Sorensen <jes@trained-monkey.org>,
Xiao Ni <xni@redhat.com>, Guoqing Jiang <guoqing.jiang@linux.dev>
Subject: Re: [PATCH mdadm 0/2] Bug fixes for --write-zeros option
Date: Thu, 13 Jun 2024 15:24:34 +0200 [thread overview]
Message-ID: <20240613152434.0000633e@linux.intel.com> (raw)
In-Reply-To: <20240604163837.798219-1-logang@deltatee.com>
On Tue, 4 Jun 2024 10:38:35 -0600
Logan Gunthorpe <logang@deltatee.com> wrote:
> Hi,
>
> Xiao noticed that the write-zeros tests failed randomly, especially
> with small disks. We tracked this down to an issue with signalfd which
> coallesced SIGCHLD signals into one. This is fixed by checking the
> status of all children after every SIGCHLD.
>
> While we were at it, we noticed a potential reace with SIGCHLD coming
> in before the signal was blocked in wait_for_zero_forks() and fix this
> by moving the blocking before the child creation.
>
> Thanks,
>
> Logan
>
> --
Applied!
Thanks,
Mariusz
prev parent reply other threads:[~2024-06-13 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 16:38 [PATCH mdadm 0/2] Bug fixes for --write-zeros option Logan Gunthorpe
2024-06-04 16:38 ` [PATCH mdadm 1/2] mdadm: Fix hang race condition in wait_for_zero_forks() Logan Gunthorpe
2024-06-04 21:34 ` Paul Menzel
2024-06-04 16:38 ` [PATCH mdadm 2/2] mdadm: Block SIGCHLD processes before starting children Logan Gunthorpe
2024-06-12 10:15 ` [PATCH mdadm 0/2] Bug fixes for --write-zeros option Mariusz Tkaczyk
2024-06-13 13:24 ` Mariusz Tkaczyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613152434.0000633e@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=guoqing.jiang@linux.dev \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).