From: Alexander Aring <aahringo@redhat.com>
To: teigland@redhat.com
Cc: gfs2@lists.linux.dev, song@kernel.org, yukuai3@huawei.com,
agruenba@redhat.com, mark@fasheh.com, jlbec@evilplan.org,
joseph.qi@linux.alibaba.com, gregkh@linuxfoundation.org,
rafael@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
ocfs2-devel@lists.linux.dev, lucien.xin@gmail.com,
aahringo@redhat.com
Subject: [RFC dlm/next 06/12] dlm: dlm_config_info config fields to unsigned int
Date: Wed, 14 Aug 2024 10:34:08 -0400 [thread overview]
Message-ID: <20240814143414.1877505-7-aahringo@redhat.com> (raw)
In-Reply-To: <20240814143414.1877505-1-aahringo@redhat.com>
We are using kstrtouint() to parse common integer fields. This patch
will switch to use unsigned int instead of int as we are parsing
unsigned integer values.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/config.c | 3 ++-
fs/dlm/config.h | 22 +++++++++++-----------
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index d9cde614ddd4..a98f0e746e9e 100644
--- a/fs/dlm/config.c
+++ b/fs/dlm/config.c
@@ -153,7 +153,8 @@ static ssize_t cluster_tcp_port_store(struct config_item *item,
CONFIGFS_ATTR(cluster_, tcp_port);
-static ssize_t cluster_set(int *info_field, int (*check_cb)(unsigned int x),
+static ssize_t cluster_set(unsigned int *info_field,
+ int (*check_cb)(unsigned int x),
const char *buf, size_t len)
{
unsigned int x;
diff --git a/fs/dlm/config.h b/fs/dlm/config.h
index 9cb4300cce7c..9abe71453c5e 100644
--- a/fs/dlm/config.h
+++ b/fs/dlm/config.h
@@ -30,17 +30,17 @@ extern const struct rhashtable_params dlm_rhash_rsb_params;
struct dlm_config_info {
__be16 ci_tcp_port;
- int ci_buffer_size;
- int ci_rsbtbl_size;
- int ci_recover_timer;
- int ci_toss_secs;
- int ci_scan_secs;
- int ci_log_debug;
- int ci_log_info;
- int ci_protocol;
- int ci_mark;
- int ci_new_rsb_count;
- int ci_recover_callbacks;
+ unsigned int ci_buffer_size;
+ unsigned int ci_rsbtbl_size;
+ unsigned int ci_recover_timer;
+ unsigned int ci_toss_secs;
+ unsigned int ci_scan_secs;
+ unsigned int ci_log_debug;
+ unsigned int ci_log_info;
+ unsigned int ci_protocol;
+ unsigned int ci_mark;
+ unsigned int ci_new_rsb_count;
+ unsigned int ci_recover_callbacks;
char ci_cluster_name[DLM_LOCKSPACE_LEN];
};
--
2.43.0
next prev parent reply other threads:[~2024-08-14 14:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 14:34 [RFC dlm/next 00/12] dlm: net-namespace functionality Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 01/12] dlm: introduce dlm_find_lockspace_name() Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 02/12] dlm: disallow different configs nodeid storages Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 03/12] dlm: add struct net to dlm_new_lockspace() Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 04/12] dlm: handle port as __be16 network byte order Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 05/12] dlm: use dlm_config as only cluster configuration Alexander Aring
2024-08-14 14:34 ` Alexander Aring [this message]
2024-08-14 14:34 ` [RFC dlm/next 07/12] dlm: rename config to configfs Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 08/12] kobject: add kset_type_create_and_add() helper Alexander Aring
2024-08-24 2:26 ` Greg KH
2024-08-25 19:54 ` Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 09/12] kobject: export generic helper ops Alexander Aring
2024-08-14 15:05 ` Greg KH
2024-08-14 20:47 ` Alexander Aring
2024-08-15 5:28 ` Greg KH
2024-08-14 14:34 ` [RFC dlm/next 10/12] dlm: separate dlm lockspaces per net-namespace Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 11/12] dlm: add nldlm net-namespace aware UAPI Alexander Aring
2024-08-14 14:34 ` [RFC dlm/next 12/12] gfs2: separate mount context by net-namespaces Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814143414.1877505-7-aahringo@redhat.com \
--to=aahringo@redhat.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gfs2@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=song@kernel.org \
--cc=teigland@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).