From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Keith Busch <kbusch@kernel.org>,
linux-xfs@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
hch@lst.de, axboe@kernel.dk
Subject: Re: [bug report] raid0 array mkfs.xfs hang
Date: Thu, 15 Aug 2024 07:42:11 +0200 [thread overview]
Message-ID: <20240815054211.GA12998@lst.de> (raw)
In-Reply-To: <441fb8d7-422d-440c-9e12-ab58a0401cad@oracle.com>
On Wed, Aug 14, 2024 at 06:25:39PM +0100, John Garry wrote:
> On 14/08/2024 15:52, Martin K. Petersen wrote:
>>
>> Keith,
>>
>>> Your change looks fine, though it sounds odd that md raid is changing
>>> queue_limit values outside the limits_lock. The stacking limits should
>>> have set the md device to 0 if one of the member drives doesn't
>>> support write_zeroes, right?
>>
>
> And even if we had used the limits lock to synchronize the update, that
> only synchronizes writers but not readers (of the limits).
Readers are blocked by freezing the queues (for most drivers) or
doing the internal mddev suspend for md.
So I suspect kicking off a workqueue to do the limits update will
be the right thing going ahead. For now we'll just need to hack
around by doing single reads of the field.
next prev parent reply other threads:[~2024-08-15 5:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:12 [bug report] raid0 array mkfs.xfs hang John Garry
2024-08-12 14:50 ` John Garry
2024-08-14 14:00 ` John Garry
2024-08-14 14:46 ` Keith Busch
2024-08-14 14:52 ` Martin K. Petersen
2024-08-14 17:25 ` John Garry
2024-08-15 5:42 ` Christoph Hellwig [this message]
2024-08-15 5:52 ` Christoph Hellwig
2024-08-15 6:19 ` John Garry
2024-08-15 6:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815054211.GA12998@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).