From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH RFC 4/6] md/raid0: Handle bio_split() errors
Date: Fri, 20 Sep 2024 16:10:55 +0200 [thread overview]
Message-ID: <20240920141055.GC2517@lst.de> (raw)
In-Reply-To: <20240919092302.3094725-5-john.g.garry@oracle.com>
On Thu, Sep 19, 2024 at 09:23:00AM +0000, John Garry wrote:
> Add proper bio_split() error handling. For any error, set bi_status, end
> the bio, and return.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
> drivers/md/raid0.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index 32d587524778..d8ad69620c9d 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -466,6 +466,11 @@ static void raid0_handle_discard(struct mddev *mddev, struct bio *bio)
> struct bio *split = bio_split(bio,
> zone->zone_end - bio->bi_iter.bi_sector, GFP_NOIO,
> &mddev->bio_set);
> + if (IS_ERR(split)) {
Empty line after the variable declarations. Also jumping out of the
loop to an error handling label might be beneficial here, but that's
probably up to the maintainers.
Same for the other hunk (and probably the other raid personalities).
next prev parent reply other threads:[~2024-09-20 14:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 9:22 [PATCH RFC 0/6] bio_split() error handling rework John Garry
2024-09-19 9:22 ` [PATCH RFC 1/6] block: Rework bio_split() return value John Garry
2024-09-19 15:50 ` Johannes Thumshirn
2024-09-23 7:27 ` John Garry
2024-09-20 14:07 ` Christoph Hellwig
2024-09-19 9:22 ` [PATCH RFC 2/6] block: Error an attempt to split an atomic write in bio_split() John Garry
2024-09-19 9:22 ` [PATCH RFC 3/6] block: Handle bio_split() errors in bio_submit_split() John Garry
2024-09-20 14:09 ` Christoph Hellwig
2024-09-23 10:33 ` John Garry
2024-09-19 9:23 ` [PATCH RFC 4/6] md/raid0: Handle bio_split() errors John Garry
2024-09-20 14:10 ` Christoph Hellwig [this message]
2024-09-19 9:23 ` [PATCH RFC 5/6] md/raid1: " John Garry
2024-09-20 6:58 ` Yu Kuai
2024-09-20 10:04 ` John Garry
2024-09-23 6:15 ` Yu Kuai
2024-09-23 7:44 ` John Garry
2024-09-23 8:18 ` Yu Kuai
2024-09-23 9:21 ` John Garry
2024-09-23 9:38 ` Yu Kuai
2024-09-23 10:40 ` John Garry
2024-10-23 11:16 ` John Garry
2024-10-23 11:46 ` Geoff Back
2024-10-23 12:11 ` John Garry
2024-10-24 2:10 ` Yu Kuai
2024-10-24 8:57 ` John Garry
2024-10-24 9:12 ` Yu Kuai
2024-10-24 9:56 ` John Garry
2024-10-25 1:39 ` Yu Kuai
2024-10-23 11:21 ` John Garry
2024-10-24 3:08 ` Yu Kuai
2024-10-24 13:51 ` John Garry
2024-10-25 1:24 ` Yu Kuai
2024-09-19 9:23 ` [PATCH RFC 6/6] md/raid10: " John Garry
2024-09-23 5:53 ` [PATCH RFC 0/6] bio_split() error handling rework Hannes Reinecke
2024-09-23 7:19 ` John Garry
2024-09-23 9:43 ` Hannes Reinecke
2024-09-23 10:21 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920141055.GC2517@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).