From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-raid@vger.kernel.org, yukuai3@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v3 4/4] Manage: forbid re-add to the array without metadata
Date: Wed, 20 Nov 2024 11:36:28 +0100 [thread overview]
Message-ID: <20241120113628.00002fd0@linux.intel.com> (raw)
In-Reply-To: <20241120064637.3657385-5-yukuai1@huaweicloud.com>
On Wed, 20 Nov 2024 14:46:37 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> re-add will not trigger full disk recovery, user should add a new disk
> to the array instead. Also update test/05r1-re-add-nosuper to reflect
> this.
>
Description miss information about blocking --re-add for external :)
Please add something. I know it is not supported, I just need some note like:
"I was never supported for external metadata and behavior is undefined? (please
check at least with IMSM), block it"
If it fallbacks to standard --add I'm also fine with the change because we are
making clear user interface and this will be help to avoid abuses and bug
reports. Probably no one is using that with external- I think we can take a
risk here.
For the code, LGTM.
Thanks!
Mariusz
prev parent reply other threads:[~2024-11-20 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 6:46 [PATCH v3 0/4] mdadm: remove bitmap file support Yu Kuai
2024-11-20 6:46 ` [PATCH v3 1/4] tests/04update-uuid: remove bitmap file test Yu Kuai
2024-11-20 6:46 ` [PATCH v3 2/4] tests/05r1-re-add-nosuper: " Yu Kuai
2024-11-20 6:46 ` [PATCH v3 3/4] mdadm: remove bitmap file support Yu Kuai
2024-11-20 10:27 ` Mariusz Tkaczyk
2024-11-21 1:25 ` Yu Kuai
2024-11-21 8:15 ` Mariusz Tkaczyk
2024-11-22 1:13 ` Yu Kuai
2024-11-22 7:55 ` Mariusz Tkaczyk
2024-11-22 8:04 ` Yu Kuai
2024-11-20 6:46 ` [PATCH v3 4/4] Manage: forbid re-add to the array without metadata Yu Kuai
2024-11-20 10:36 ` Mariusz Tkaczyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120113628.00002fd0@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).