From: Christoph Hellwig <hch@lst.de>
To: Xiao Ni <xni@redhat.com>
Cc: linux-raid@vger.kernel.org, song@kernel.org,
yukuai1@huaweicloud.com, ming.lei@redhat.com, ncroxon@redhat.com
Subject: Re: [RFC PATCH 1/1] md: delete gendisk in ioctl path
Date: Tue, 22 Apr 2025 15:48:51 +0200 [thread overview]
Message-ID: <20250422134851.GA23131@lst.de> (raw)
In-Reply-To: <CALTww2-L_29Zpdf1VKQccO-O+=FSGErLakbj-dk4ZDpidr4_5A@mail.gmail.com>
On Tue, Apr 22, 2025 at 04:31:57PM +0800, Xiao Ni wrote:
> There is another reason that I want to put del_gendisk in the ioctl
> path. Because sometimes device node can still exist after command
> mdadm --stop. del_gendisk removes inode first and then removes device
> node (e.g. /dev/md0). So there is a small window that device node can
> be open again. Then some strange things happen. Sometimes the array is
> created but device node can't be created (I guess it's removed by
> devtempfs?). Sometimes the kernel message prints "block device
> autoloading is deprecated and will be removed".
FYI, I'm all for sorting out the md gendisk lifetime and probing
mess. But let's do that separately from a regression fix as changes
in the area are intricate and might cause further regressions.
next prev parent reply other threads:[~2025-04-22 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 3:24 [RFC PATCH 1/1] md: delete gendisk in ioctl path Xiao Ni
2025-04-22 5:51 ` Christoph Hellwig
2025-04-22 8:31 ` Xiao Ni
2025-04-22 8:40 ` Xiao Ni
2025-04-22 13:48 ` Christoph Hellwig [this message]
2025-04-22 9:24 ` Xiao Ni
2025-04-22 6:21 ` Yu Kuai
2025-04-22 7:31 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422134851.GA23131@lst.de \
--to=hch@lst.de \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ncroxon@redhat.com \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox