Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Ryo Takakura <ryotkkr98@gmail.com>
To: song@kernel.org, yukuai3@huawei.com, tj@kernel.org
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ryo Takakura <ryotkkr98@gmail.com>
Subject: [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue
Date: Sun,  1 Jun 2025 10:37:02 +0900	[thread overview]
Message-ID: <20250601013702.64640-1-ryotkkr98@gmail.com> (raw)

When specified with WQ_CPU_INTENSIVE, the workqueue doesn't
participate in concurrency management. This behaviour is already
accounted for WQ_UNBOUND workqueues given that they are assigned
to their own worker threads.

Unset WQ_CPU_INTENSIVE as the use of flag has no effect when
used with WQ_UNBOUND.

Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
---

Hi!

My understanding is that unbound wqs are served by non concurrency
managed worker threads and is not tracked by wq_cpu_intensive_report(),
so this should have no change in behaviour.

Sincerely,
Ryo Takakura

---
 drivers/md/raid5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 638938316..8f3b45161 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -9048,7 +9048,7 @@ static int __init raid5_init(void)
 	int ret;
 
 	raid5_wq = alloc_workqueue("raid5wq",
-		WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_CPU_INTENSIVE|WQ_SYSFS, 0);
+		WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_SYSFS, 0);
 	if (!raid5_wq)
 		return -ENOMEM;
 
-- 
2.34.1


             reply	other threads:[~2025-06-01  1:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01  1:37 Ryo Takakura [this message]
2025-06-02 17:23 ` [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue Tejun Heo
2025-06-14  6:42 ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250601013702.64640-1-ryotkkr98@gmail.com \
    --to=ryotkkr98@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox