From: Roman Mamedov <rm@romanrm.net>
To: "Yu Kuai" <yukuai@fnnas.com>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
<linan666@huaweicloud.com>, <stable@vger.kernel.org>,
<song@kernel.org>, <linux-raid@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yangerkun@huawei.com>,
<yi.zhang@huawei.com>
Subject: Re: [PATCH stable/6.18-6.17] md: add check_new_feature module parameter
Date: Wed, 17 Dec 2025 22:31:30 +0500 [thread overview]
Message-ID: <20251217223130.1c571fa5@nvm> (raw)
In-Reply-To: <6979cd43-d38c-477d-857c-8d211bc85474@fnnas.com>
On Thu, 18 Dec 2025 01:11:43 +0800
"Yu Kuai" <yukuai@fnnas.com> wrote:
> Hi,
>
> 在 2025/12/17 22:04, Greg KH 写道:
> > On Wed, Dec 17, 2025 at 09:05:13PM +0800, linan666@huaweicloud.com wrote:
> >> From: Li Nan <linan122@huawei.com>
> >>
> >> commit 9c47127a807da3e36ce80f7c83a1134a291fc021 upstream.
> >>
> >> Raid checks if pad3 is zero when loading superblock from disk. Arrays
> >> created with new features may fail to assemble on old kernels as pad3
> >> is used.
> >>
> >> Add module parameter check_new_feature to bypass this check.
> > This is a new feature, why does it need to go to stable kernels?
> >
> > And a module parameter? Ugh, this isn't the 1990's anymore, this is not
> > good and will be a mess over time (think multiple devices...)
>
> Nan didn't mention the background. We won't backport the new feature to stable
> kernels(Although this fix a data lost problem in the case array is created
> with disks in different lbs, anyone is interested can do this). However, this
> backport is just used to provide a possible solution for user to still assemble
> arrays after switching to old LTS kernels when they are using the default lbs.
This is still a bad scenario. Original problem:
- Boot into a new kernel once, reboot into the old one, the existing array no
longer works.
After this patch:
- Same. Unless you know how, where and which module parameter to add, to
be passed to md module on load. Might be not convenient if the root FS
didn't assemble and mount and is inaccessible.
Not ideal whatsoever.
Wouldn't it be possible to implement minimal *automatic* recognition (and
ignoring) of those newly utilized bits instead?
--
With respect,
Roman
next prev parent reply other threads:[~2025-12-17 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 13:05 [PATCH stable/6.18-6.17] md: add check_new_feature module parameter linan666
2025-12-17 14:04 ` Greg KH
2025-12-17 17:11 ` Yu Kuai
2025-12-17 17:31 ` Roman Mamedov [this message]
2025-12-18 6:30 ` Greg KH
2025-12-18 6:57 ` Li Nan
2025-12-18 7:14 ` Greg KH
2025-12-18 7:42 ` Li Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217223130.1c571fa5@nvm \
--to=rm@romanrm.net \
--cc=gregkh@linuxfoundation.org \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox