* [PATCH v2 0/3] lib/raid6: Optimize raid6_select_algo while ensuring
@ 2026-02-06 5:43 sunliming
2026-02-06 5:43 ` [PATCH v2 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts sunliming
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: sunliming @ 2026-02-06 5:43 UTC (permalink / raw)
To: song, yukuai; +Cc: linux-raid, linux-kernel, linan666, sunliming
From: sunliming <sunliming@kylinos.cn>
The selection of RAID6 PQ functions involves a dual-strategy approach:
prioritizing startup speed leads to quickly choosing a usable algorithm,
while prioritizing performance leads to selecting an optimal algorithm
via benchmarking. This choice is determined by the RAID6_PQ_BENCHMARK
configuration. This patch series achieves both fast startup and optimal
algorithm selection by initially choosing an algorithm quickly at startup,
then asynchronously determining the optimal algorithm through benchmarking.
Since all RAID6 PQ function algorithms are functionally equivalent despite
performance differences, this approach should be effective.
---
Changes in v2:
Select the highest-priority algorithm instead of the first one.
Add the cancel_work_sync function in the exit function to handle the
work queue cleanup.
instead of the first one.
---
sunliming (3):
lib/raid6: Divide the raid6 algorithm selection process into two parts
lib/raid6: Optimizing the raid6_select_algo time through asynchronous
processing
lib/raid6: Delete the RAID6_PQ_BENCHMARK config
include/linux/raid/pq.h | 3 --
lib/Kconfig | 8 ----
lib/raid6/algos.c | 97 +++++++++++++++++++++++++++++------------
3 files changed, 68 insertions(+), 40 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts 2026-02-06 5:43 [PATCH v2 0/3] lib/raid6: Optimize raid6_select_algo while ensuring sunliming @ 2026-02-06 5:43 ` sunliming 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming 2026-02-06 5:43 ` [PATCH v2 3/3] lib/raid6: Delete the RAID6_PQ_BENCHMARK config sunliming 2 siblings, 0 replies; 9+ messages in thread From: sunliming @ 2026-02-06 5:43 UTC (permalink / raw) To: song, yukuai; +Cc: linux-raid, linux-kernel, linan666, sunliming From: sunliming <sunliming@kylinos.cn> Divide the RAID6 algorithm selection process into two parts: fast selection and benchmark selection. To prepare for the asynchronous processing of the benchmark phase. Signed-off-by: sunliming <sunliming@kylinos.cn> --- lib/raid6/algos.c | 85 +++++++++++++++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 28 deletions(-) diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c index 799e0e5eac26..a14469388b0c 100644 --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -134,7 +134,7 @@ const struct raid6_recov_calls *const raid6_recov_algos[] = { static inline const struct raid6_recov_calls *raid6_choose_recov(void) { const struct raid6_recov_calls *const *algo; - const struct raid6_recov_calls *best; + const struct raid6_recov_calls *best = NULL; for (best = NULL, algo = raid6_recov_algos; *algo; algo++) if (!best || (*algo)->priority > best->priority) @@ -152,24 +152,43 @@ static inline const struct raid6_recov_calls *raid6_choose_recov(void) return best; } -static inline const struct raid6_calls *raid6_choose_gen( - void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) +/* Quick selection: selects the first valid algorithm. */ +static inline int raid6_choose_gen_fast(void) +{ + int ret = 0; + const struct raid6_calls *const *algo; + const struct raid6_calls *best = NULL; + + for (best = NULL, algo = raid6_algos; *algo; algo++) + if (!best || (*algo)->priority > best->priority) + if (!(*algo)->valid || (*algo)->valid()) + best = *algo; + + if (best) { + raid6_call = *best; + pr_info("raid6: skipped pq benchmark and selected %s\n", + best->name); + } else { + pr_err("raid6: No valid algorithm found even for fast selection!\n"); + ret = -EINVAL; + } + + return ret; +} + +static inline const struct raid6_calls *raid6_gen_benchmark( + void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) { unsigned long perf, bestgenperf, j0, j1; int start = (disks>>1)-1, stop = disks-3; /* work on the second half of the disks */ const struct raid6_calls *const *algo; - const struct raid6_calls *best; + const struct raid6_calls *best = NULL; for (bestgenperf = 0, best = NULL, algo = raid6_algos; *algo; algo++) { if (!best || (*algo)->priority >= best->priority) { if ((*algo)->valid && !(*algo)->valid()) continue; - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - best = *algo; - break; - } - perf = 0; preempt_disable(); @@ -200,12 +219,6 @@ static inline const struct raid6_calls *raid6_choose_gen( raid6_call = *best; - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - pr_info("raid6: skipped pq benchmark and selected %s\n", - best->name); - goto out; - } - pr_info("raid6: using algorithm %s gen() %ld MB/s\n", best->name, (bestgenperf * HZ * (disks - 2)) >> @@ -230,24 +243,19 @@ static inline const struct raid6_calls *raid6_choose_gen( (perf * HZ * (disks - 2)) >> (20 - PAGE_SHIFT + RAID6_TIME_JIFFIES_LG2 + 1)); } - out: return best; } - /* Try to pick the best algorithm */ /* This code uses the gfmul table as convenient data set to abuse */ - -int __init raid6_select_algo(void) +static int raid6_choose_gen_benmark(void) { const int disks = RAID6_TEST_DISKS; - - const struct raid6_calls *gen_best; - const struct raid6_recov_calls *rec_best; char *disk_ptr, *p; void *dptrs[RAID6_TEST_DISKS]; - int i, cycle; + const struct raid6_calls *best = NULL; + int i, cycle, ret = 0; /* prepare the buffer and fill it circularly with gfmul table */ disk_ptr = (char *)__get_free_pages(GFP_KERNEL, RAID6_TEST_DISKS_ORDER); @@ -269,15 +277,36 @@ int __init raid6_select_algo(void) if ((disks - 2) * PAGE_SIZE % 65536) memcpy(p, raid6_gfmul, (disks - 2) * PAGE_SIZE % 65536); - /* select raid gen_syndrome function */ - gen_best = raid6_choose_gen(&dptrs, disks); + best = raid6_gen_benchmark(&dptrs, disks); + if (!best) + ret = -EINVAL; + + free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); + + return ret; +} + +int __init raid6_select_algo(void) +{ + int ret = 0; + const struct raid6_recov_calls *rec_best = NULL; + + /* select raid gen_syndrome functions */ + if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) + ret = raid6_choose_gen_fast(); + else + ret = raid6_choose_gen_benmark(); + + if (ret < 0) + goto out; /* select raid recover functions */ rec_best = raid6_choose_recov(); + if (!rec_best) + ret = -EINVAL; - free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); - - return gen_best && rec_best ? 0 : -EINVAL; +out: + return ret; } static void raid6_exit(void) -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 [PATCH v2 0/3] lib/raid6: Optimize raid6_select_algo while ensuring sunliming 2026-02-06 5:43 ` [PATCH v2 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts sunliming @ 2026-02-06 5:43 ` sunliming 2026-02-06 19:22 ` kernel test robot ` (4 more replies) 2026-02-06 5:43 ` [PATCH v2 3/3] lib/raid6: Delete the RAID6_PQ_BENCHMARK config sunliming 2 siblings, 5 replies; 9+ messages in thread From: sunliming @ 2026-02-06 5:43 UTC (permalink / raw) To: song, yukuai; +Cc: linux-raid, linux-kernel, linan666, sunliming From: sunliming <sunliming@kylinos.cn> Optimizing the raid6_select_algo time. In raid6_select_algo(), an raid6 gen algorithm is first selected quickly through synchronous processing, while the time-consuming process of selecting the optimal algorithm via benchmarking is handled asynchronously. This approach speeds up the overall startup time and ultimately ensures the selection of an optimal algorithm. Signed-off-by: sunliming <sunliming@kylinos.cn> --- lib/raid6/algos.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c index a14469388b0c..a3c94641a8e5 100644 --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -12,6 +12,7 @@ */ #include <linux/raid/pq.h> +#include <linux/workqueue.h> #ifndef __KERNEL__ #include <sys/mman.h> #include <stdio.h> @@ -166,7 +167,7 @@ static inline int raid6_choose_gen_fast(void) if (best) { raid6_call = *best; - pr_info("raid6: skipped pq benchmark and selected %s\n", + pr_info("raid6: fast selected %s, async benchmark pending\n", best->name); } else { pr_err("raid6: No valid algorithm found even for fast selection!\n"); @@ -213,7 +214,7 @@ static inline const struct raid6_calls *raid6_gen_benchmark( } if (!best) { - pr_err("raid6: Yikes! No algorithm found!\n"); + pr_warn("raid6: async benchmark failed to find any algorithm\n"); goto out; } @@ -286,24 +287,33 @@ static int raid6_choose_gen_benmark(void) return ret; } +static struct work_struct raid6_benchmark_work __initdata; + +static __init void benchmark_work_func(struct work_struct *work) +{ + raid6_choose_gen_benmark(); +} + int __init raid6_select_algo(void) { int ret = 0; const struct raid6_recov_calls *rec_best = NULL; - /* select raid gen_syndrome functions */ - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) - ret = raid6_choose_gen_fast(); - else - ret = raid6_choose_gen_benmark(); - + /* phase 1: synchronous fast selection generation algorithm */ + ret = raid6_choose_gen_fast(); if (ret < 0) goto out; /* select raid recover functions */ rec_best = raid6_choose_recov(); - if (!rec_best) + if (!rec_best) { ret = -EINVAL; + goto out; + } + + /* phase 2: asynchronous performance benchmarking */ + INIT_WORK(&raid6_benchmark_work, benchmark_work_func); + schedule_work(&raid6_benchmark_work); out: return ret; @@ -311,7 +321,7 @@ int __init raid6_select_algo(void) static void raid6_exit(void) { - do { } while (0); + cancel_work_sync(&raid6_benchmark_work); } subsys_initcall(raid6_select_algo); -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming @ 2026-02-06 19:22 ` kernel test robot 2026-02-06 19:34 ` kernel test robot ` (3 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2026-02-06 19:22 UTC (permalink / raw) To: sunliming, song, yukuai Cc: oe-kbuild-all, linux-raid, linux-kernel, linan666, sunliming Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on linus/master v6.16-rc1 next-20260205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sunliming-linux-dev/lib-raid6-Divide-the-raid6-algorithm-selection-process-into-two-parts/20260206-134850 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20260206054341.106878-3-sunliming%40linux.dev patch subject: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing config: arm64-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260206/202602062027.j08UeCWD-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260206/202602062027.j08UeCWD-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202602062027.j08UeCWD-lkp@intel.com/ All warnings (new ones prefixed by >>, old ones prefixed by <<): >> WARNING: modpost: lib/raid6/raid6_pq: section mismatch in reference: raid6_exit+0xc (section: .text) -> raid6_benchmark_work (section: .init.data) WARNING: modpost: lib/raid6/raid6_pq: section mismatch in reference: raid6_exit+0x10 (section: .text) -> raid6_benchmark_work (section: .init.data) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming 2026-02-06 19:22 ` kernel test robot @ 2026-02-06 19:34 ` kernel test robot 2026-02-07 6:51 ` kernel test robot ` (2 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2026-02-06 19:34 UTC (permalink / raw) To: sunliming, song, yukuai Cc: llvm, oe-kbuild-all, linux-raid, linux-kernel, linan666, sunliming Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on linus/master v6.16-rc1 next-20260205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sunliming-linux-dev/lib-raid6-Divide-the-raid6-algorithm-selection-process-into-two-parts/20260206-134850 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20260206054341.106878-3-sunliming%40linux.dev patch subject: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260206/202602062049.sdwQ1NiZ-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260206/202602062049.sdwQ1NiZ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202602062049.sdwQ1NiZ-lkp@intel.com/ All warnings (new ones prefixed by >>, old ones prefixed by <<): >> WARNING: modpost: lib/raid6/raid6_pq: section mismatch in reference: cleanup_module+0xc (section: .text) -> raid6_benchmark_work (section: .init.data) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming 2026-02-06 19:22 ` kernel test robot 2026-02-06 19:34 ` kernel test robot @ 2026-02-07 6:51 ` kernel test robot 2026-02-07 7:22 ` kernel test robot 2026-02-13 2:34 ` kernel test robot 4 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2026-02-07 6:51 UTC (permalink / raw) To: sunliming, song, yukuai Cc: oe-kbuild-all, linux-raid, linux-kernel, linan666, sunliming Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on linus/master v6.19-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sunliming-linux-dev/lib-raid6-Divide-the-raid6-algorithm-selection-process-into-two-parts/20260206-134850 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20260206054341.106878-3-sunliming%40linux.dev patch subject: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing config: arc-randconfig-001-20260207 (https://download.01.org/0day-ci/archive/20260207/202602071412.HND36w5Q-lkp@intel.com/config) compiler: arc-linux-gcc (GCC) 9.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602071412.HND36w5Q-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202602071412.HND36w5Q-lkp@intel.com/ All warnings (new ones prefixed by >>, old ones prefixed by <<): >> WARNING: modpost: lib/raid6/raid6_pq: section mismatch in reference: raid6_exit+0x2 (section: .text) -> raid6_benchmark_work (section: .init.data) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming ` (2 preceding siblings ...) 2026-02-07 6:51 ` kernel test robot @ 2026-02-07 7:22 ` kernel test robot 2026-02-13 2:34 ` kernel test robot 4 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2026-02-07 7:22 UTC (permalink / raw) To: sunliming, song, yukuai Cc: oe-kbuild-all, linux-raid, linux-kernel, linan666, sunliming Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on linus/master v6.19-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sunliming-linux-dev/lib-raid6-Divide-the-raid6-algorithm-selection-process-into-two-parts/20260206-134850 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20260206054341.106878-3-sunliming%40linux.dev patch subject: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing config: i386-buildonly-randconfig-001-20260207 (https://download.01.org/0day-ci/archive/20260207/202602071500.ctQs6ZeY-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602071500.ctQs6ZeY-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202602071500.ctQs6ZeY-lkp@intel.com/ All warnings (new ones prefixed by >>, old ones prefixed by <<): >> WARNING: modpost: vmlinux: section mismatch in reference: raid6_exit+0x9 (section: .text) -> raid6_benchmark_work (section: .init.data) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming ` (3 preceding siblings ...) 2026-02-07 7:22 ` kernel test robot @ 2026-02-13 2:34 ` kernel test robot 4 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2026-02-13 2:34 UTC (permalink / raw) To: sunliming Cc: oe-lkp, lkp, linux-raid, song, yukuai, linux-kernel, linan666, sunliming, oliver.sang Hello, kernel test robot noticed "Oops:int3:#[##]SMP_KASAN_NOPTI" on: commit: 9931f8d4a042e5e2cbf74d9ee99ece44da404284 ("[PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing") url: https://github.com/intel-lab-lkp/linux/commits/sunliming-linux-dev/lib-raid6-Divide-the-raid6-algorithm-selection-process-into-two-parts/20260206-134850 base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/all/20260206054341.106878-3-sunliming@linux.dev/ patch subject: [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing in testcase: perf-sanity-tests version: with following parameters: perf_compiler: gcc group: group-00 config: x86_64-rhel-9.4-bpf compiler: gcc-14 test machine: 16 threads 1 sockets Intel(R) Xeon(R) E-2278G CPU @ 3.40GHz (Coffee Lake-E) with 32G memory (please refer to attached dmesg/kmsg for entire log/backtrace) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <oliver.sang@intel.com> | Closes: https://lore.kernel.org/oe-lkp/202602131016.5ce5a38e-lkp@intel.com [ 81.049609][ C15] Oops: int3: 0000 [#1] SMP KASAN NOPTI [ 81.049615][ C15] CPU: 15 UID: 0 PID: 109 Comm: kworker/15:0 Tainted: G S 6.19.0-rc6-00175-g9931f8d4a042 #1 PREEMPT(full) [ 81.049621][ C15] Tainted: [S]=CPU_OUT_OF_SPEC [ 81.049622][ C15] Hardware name: Intel Corporation Mehlow UP Server Platform/Moss Beach Server, BIOS CNLSE2R1.R00.X188.B13.1903250419 03/25/2019 [ 81.049625][ C15] Workqueue: events benchmark_work_func [raid6_pq] [ 81.049631][ C15] RIP: 0010:benchmark_work_func (kbuild/src/consumer/lib/raid6/recov.c:65) raid6_pq [ 81.049650][ C15] Code: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc <cc> cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc All code ======== 0: cc int3 1: cc int3 2: cc int3 3: cc int3 4: cc int3 5: cc int3 6: cc int3 7: cc int3 8: cc int3 9: cc int3 a: cc int3 b: cc int3 c: cc int3 d: cc int3 e: cc int3 f: cc int3 10: cc int3 11: cc int3 12: cc int3 13: cc int3 14: cc int3 15: cc int3 16: cc int3 17: cc int3 18: cc int3 19: cc int3 1a: cc int3 1b: cc int3 1c: cc int3 1d: cc int3 1e: cc int3 1f: cc int3 20: cc int3 21: cc int3 22: cc int3 23: cc int3 24: cc int3 25: cc int3 26: cc int3 27: cc int3 28: cc int3 29: cc int3 2a:* cc int3 <-- trapping instruction 2b: cc int3 2c: cc int3 2d: cc int3 2e: cc int3 2f: cc int3 30: cc int3 31: cc int3 32: cc int3 33: cc int3 34: cc int3 35: cc int3 36: cc int3 37: cc int3 38: cc int3 39: cc int3 3a: cc int3 3b: cc int3 3c: cc int3 3d: cc int3 3e: cc int3 3f: cc int3 Code starting with the faulting instruction =========================================== 0: cc int3 1: cc int3 2: cc int3 3: cc int3 4: cc int3 5: cc int3 6: cc int3 7: cc int3 8: cc int3 9: cc int3 a: cc int3 b: cc int3 c: cc int3 d: cc int3 e: cc int3 f: cc int3 10: cc int3 11: cc int3 12: cc int3 13: cc int3 14: cc int3 15: cc int3 [ 81.049653][ C15] RSP: 0018:ffff888101557b58 EFLAGS: 00000286 [ 81.049656][ C15] RAX: ffffffffc115b5a0 RBX: 1ffff110202aaf6b RCX: 0000000000000000 [ 81.049658][ C15] RDX: ffffffffc115b6e0 RSI: ffffffff81513d9c RDI: ffffed10202aaf56 [ 81.049660][ C15] RBP: ffff88886bdf0000 R08: 0000000000000000 R09: fffffbfff0b21e14 [ 81.049662][ C15] R10: ffffffff8590f0a7 R11: 0000000000000001 R12: ffff888101557bb8 [ 81.049664][ C15] R13: ffff88886bdf8000 R14: ffff888101557bb8 R15: ffff8887887c33c0 [ 81.049667][ C15] FS: 0000000000000000(0000) GS:ffff888801e6a000(0000) knlGS:0000000000000000 [ 81.049669][ C15] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 81.049671][ C15] CR2: 00007f33621da000 CR3: 00000002f20ed006 CR4: 00000000003726f0 [ 81.049674][ C15] Call Trace: [ 81.049676][ C15] <TASK> [ 81.049680][ C15] ? rcu_is_watching (kbuild/src/consumer/arch/x86/include/asm/atomic.h:23 kbuild/src/consumer/include/linux/atomic/atomic-arch-fallback.h:457 kbuild/src/consumer/include/linux/context_tracking.h:128 kbuild/src/consumer/kernel/rcu/tree.c:751) [ 81.049685][ C15] ? rcu_is_watching (kbuild/src/consumer/arch/x86/include/asm/atomic.h:23 kbuild/src/consumer/include/linux/atomic/atomic-arch-fallback.h:457 kbuild/src/consumer/include/linux/context_tracking.h:128 kbuild/src/consumer/kernel/rcu/tree.c:751) [ 81.049689][ C15] ? lock_acquire (kbuild/src/consumer/include/trace/events/lock.h:24 (discriminator 2) kbuild/src/consumer/kernel/locking/lockdep.c:5831 (discriminator 2)) [ 81.049694][ C15] ? process_one_work (kbuild/src/consumer/arch/x86/include/asm/jump_label.h:37 kbuild/src/consumer/include/trace/events/workqueue.h:110 kbuild/src/consumer/kernel/workqueue.c:3262) The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20260213/202602131016.5ce5a38e-lkp@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] lib/raid6: Delete the RAID6_PQ_BENCHMARK config 2026-02-06 5:43 [PATCH v2 0/3] lib/raid6: Optimize raid6_select_algo while ensuring sunliming 2026-02-06 5:43 ` [PATCH v2 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts sunliming 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming @ 2026-02-06 5:43 ` sunliming 2 siblings, 0 replies; 9+ messages in thread From: sunliming @ 2026-02-06 5:43 UTC (permalink / raw) To: song, yukuai; +Cc: linux-raid, linux-kernel, linan666, sunliming From: sunliming <sunliming@kylinos.cn> Now RAID6 PQ functions is automatically choosed and the RAID6_PQ_BENCHMARK is not needed. Signed-off-by: sunliming <sunliming@kylinos.cn> --- include/linux/raid/pq.h | 3 --- lib/Kconfig | 8 -------- 2 files changed, 11 deletions(-) diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h index 2467b3be15c9..6378ec4ae4ba 100644 --- a/include/linux/raid/pq.h +++ b/include/linux/raid/pq.h @@ -67,9 +67,6 @@ extern const char raid6_empty_zero_page[PAGE_SIZE]; #define MODULE_DESCRIPTION(desc) #define subsys_initcall(x) #define module_exit(x) - -#define IS_ENABLED(x) (x) -#define CONFIG_RAID6_PQ_BENCHMARK 1 #endif /* __KERNEL__ */ /* Routine choices */ diff --git a/lib/Kconfig b/lib/Kconfig index 2923924bea78..841a0245a2c4 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -11,14 +11,6 @@ menu "Library routines" config RAID6_PQ tristate -config RAID6_PQ_BENCHMARK - bool "Automatically choose fastest RAID6 PQ functions" - depends on RAID6_PQ - default y - help - Benchmark all available RAID6 PQ functions on init and choose the - fastest one. - config LINEAR_RANGES tristate -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-02-13 2:34 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-02-06 5:43 [PATCH v2 0/3] lib/raid6: Optimize raid6_select_algo while ensuring sunliming 2026-02-06 5:43 ` [PATCH v2 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts sunliming 2026-02-06 5:43 ` [PATCH v2 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing sunliming 2026-02-06 19:22 ` kernel test robot 2026-02-06 19:34 ` kernel test robot 2026-02-07 6:51 ` kernel test robot 2026-02-07 7:22 ` kernel test robot 2026-02-13 2:34 ` kernel test robot 2026-02-06 5:43 ` [PATCH v2 3/3] lib/raid6: Delete the RAID6_PQ_BENCHMARK config sunliming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox