From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C753E274A; Tue, 19 May 2026 08:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779179086; cv=none; b=KaDA1pKHe5/A0Z/W5PuVQG+D4F2IucC4k0CST1ttwO6/knjB/w19+tj/0gChVqpmb5MKxgBg3QZSw9LabUcXzORaLXYBXLFBNNEFqBzTBf39sSAhw/UviwNAk788cVlO0LA51sthziuitKO6+aMwVIkk4lYRzp3sXmH/r3OkiJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779179086; c=relaxed/simple; bh=WddjLMCxE2Qnvqhi02yA5fGkqdgfSy+rWBfhjD3zYLU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QBOE/APCUu0YG3E97NYW5hZo5TAL5u115ExRuHRL8QgdrDf+QoBEOZbXjyMQAjfhn+spBGZUQZkvCjbVbfRDT2xiO2nlnBLsWLWhE+PfOcCJF4QWCtnwSEeH921w+EalC94QFb5OPHCHkjCaPR1sbUtfrn30J2hpH0UfUFnPueg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C9A0568D0D; Tue, 19 May 2026 10:24:33 +0200 (CEST) Date: Tue, 19 May 2026 10:24:32 +0200 From: Christoph Hellwig To: Andrew Morton Cc: Christoph Hellwig , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: cleanup the RAID6 P/Q library v3 Message-ID: <20260519082432.GA14956@lst.de> References: <20260518051804.462141-1-hch@lst.de> <20260518141205.c100f76eec5f58e78bbbf7af@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518141205.c100f76eec5f58e78bbbf7af@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, May 18, 2026 at 02:12:05PM -0700, Andrew Morton wrote: > Cool, I'll add this to mm.git's mm-nonmm-unstable branch for some > linux-next testing. > > AI review found quite a lot to talk about: > https://sashiko.dev/#/patchset/20260518051804.462141-1-hch@lst.de Not a lot of it is very useful, though: raid6: turn the userspace test harness into a kunit test - complains about basically adding need_resched, which we've decided we won't do now that we have lazy preempt. This is probably going to come up in lots of places because of the old training data raid6: use named initializers for struct raid6_calls - whining about keeping totally pointless comments raid6: warn when using less than four devices - complains about warning for btrfs which is clearly documented as the outcome in the commit log - and also complaining that the enforcement isn't hard enough, but the WARN_ON is the best we can do here raid6: rework registration of optimized algorithms - less registration causing less kunit coverage: that's intentional as it keeps testing time down and similar to other arch optimized tests in crc and crypto code. It also doesn't really reduce coverage as before this series there was none. raid6: use static_call for gen_syndrom and xor_syndrom - doesn't seem to know that bool fails when an initcall fails raid6_kunit: use KUNIT_CASE_PARAM - whining about the code style. I don't really like it either, but the kunit case stuff is a mess There are a few somewhat useful things, though. raid6: hide internals - yes, the -I is duplicate and should be fixed raid6: rework registration of optimized algorithms - avx2 instead of avx512 is probably the right thing for no benchmarking, but if it was intentional (it wasn't), that should be document. So I'll just switch back to the previous version to keep the state of the art