From: Yunye Zhao <yunye.zhao@linux.alibaba.com>
To: yukuai@fygo.io
Cc: joseph.qi@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, magiclinan@didiglobal.com,
sashiko-bot@kernel.org, song@kernel.org, xiao@kernel.org,
yunye.zhao@linux.alibaba.com
Subject: Re: [PATCH v2 3/3] md/raid10: skip clean regions in bulk during recovery
Date: Fri, 7 Aug 2026 17:05:19 +0800 [thread overview]
Message-ID: <20260807090519.122115-1-yunye.zhao@linux.alibaba.com> (raw)
In-Reply-To: <e22f9816-fb97-49aa-a4d2-b098ccafb654@fygo.io>
Hi Kuai,
On 2026/8/7, Yu Kuai wrote:
>> If I read you right, you would prefer this fixed on the bitmap side
>> rather than in raid10.c.
>
> I still don't get why
Sorry, I misread your earlier reply. I had read it as "the whole thing
belongs in md-bitmap.c", i.e. that bitmap_start_sync() should hand back a
device-space span, which is why I said md-bitmap.c would need the raid10
geometry. That is not what you were saying.
I think the split is this: the first half belongs in md, in array address
space - bitmap_start_sync() should report a much larger clean span,
ideally up to the full array size - and the second half, the array ->
member conversion and the minimum over the members, is what 3/3 already
does.
> Check the code, currently raid10 do not map the max_sync, which is RESYNC_PAGES, back
> to rdev sector, and use it directly. I wonder is this safe for raid10 with chunksize less
> than RESYNC_PAGES?
Good point, v2 does not address that. Let me think it through properly
and handle it in the next version.
Thanks,
Yunye
prev parent reply other threads:[~2026-08-07 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 6:27 [PATCH] md: fix soft lockup during resync when sync is repeatedly skipped Yunye Zhao
2026-07-17 6:51 ` sashiko-bot
2026-07-19 10:45 ` yu kuai
2026-07-20 6:20 ` Yunye Zhao
2026-07-22 4:00 ` yu kuai
2026-07-23 13:55 ` [PATCH v2 0/3] md/raid10: fix recovery corruption and soft lockup on large arrays Yunye Zhao
2026-07-23 13:55 ` [PATCH v2 1/3] md/raid10: fix still_degraded being inverted in raid10_sync_request() Yunye Zhao
2026-07-26 12:25 ` Mykola Marzhan
2026-07-27 2:43 ` Yunye Zhao
2026-08-07 8:11 ` yu kuai
2026-07-23 13:55 ` [PATCH v2 2/3] md: add cond_resched() to md_do_sync()'s skip path Yunye Zhao
2026-07-23 14:05 ` sashiko-bot
2026-08-07 8:11 ` yu kuai
2026-07-23 13:55 ` [PATCH v2 3/3] md/raid10: skip clean regions in bulk during recovery Yunye Zhao
2026-07-23 14:16 ` sashiko-bot
2026-07-31 9:46 ` yu kuai
2026-08-04 3:55 ` Yunye Zhao
2026-08-04 6:57 ` yu kuai
2026-08-04 9:01 ` Yunye Zhao
2026-08-04 11:47 ` yu kuai
2026-08-07 9:05 ` Yunye Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807090519.122115-1-yunye.zhao@linux.alibaba.com \
--to=yunye.zhao@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=magiclinan@didiglobal.com \
--cc=sashiko-bot@kernel.org \
--cc=song@kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox