From: "Dirk Müller" <dmueller@suse.de>
To: Song Liu <song@kernel.org>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] fix multiple definition linking error due to missing extern
Date: Tue, 08 Feb 2022 17:51:30 +0100 [thread overview]
Message-ID: <2235987.xdJb8MTqgy@magnolia> (raw)
In-Reply-To: <CAPhsuW58UrCJMgKiW0mRSMbc00UoZtY=944Ut1SvjDHewM+gmA@mail.gmail.com>
On Dienstag, 8. Februar 2022 06:45:45 CET Song Liu wrote:
Hi Song,
> > -struct raid6_calls raid6_call;
> > +extern struct raid6_calls raid6_call;
>
> Can we just remove this line?
oh yes indeed, it is already declared in the header file. that is much simpler.
I've sent a PATCH v2 just now.
Thank you,
Dirk
next prev parent reply other threads:[~2022-02-08 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 20:51 [PATCH] fix multiple definition linking error due to missing extern Dirk Müller
2022-02-07 7:48 ` Paul Menzel
2022-02-08 5:45 ` Song Liu
2022-02-08 16:51 ` Dirk Müller [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-29 15:38 Dirk Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2235987.xdJb8MTqgy@magnolia \
--to=dmueller@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).