From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B30892D7DFF for ; Wed, 10 Sep 2025 11:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504478; cv=none; b=BSFeBAKbXaLzbUxWdmDoOwbNMri+pdUYwk/bdSOX6nFYmX9JUnW/+Wdd9KxdxMQWNAymmnXyUYRkuDy+uq0KGNIWqXiU/mptFxdoraL4J1eMEB5OErO0MfppWaJ/xb0RFU+dqDl2Wxs1buVQwarli0Yd3lVBHLjzdTA1g8j7t5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504478; c=relaxed/simple; bh=ghP75ITTr1Wbl8YiC9b7VSPLJvLHnLZXtrGBe0Jldgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L9ud+Ov5PvFgWVQjba4rplG0Y2LxqlqxAwP2MLklCfxFet9i4f71DbGaRkmUaw86qM8yHdNT2JapVeITCaYi5bt6kLmmBxAek/QICcKiiz7qdkdLs6pPl/CIerVh7dtoBj2tXvLeUxYxRZ21Tu4ZDnXvPzhoSQS+ZrEqOEjF6GI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Do8T5X9t; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OMvVrlQA; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Do8T5X9t; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OMvVrlQA; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Do8T5X9t"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OMvVrlQA"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Do8T5X9t"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OMvVrlQA" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 49FFB21CAA; Wed, 10 Sep 2025 11:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757504471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nukXpjG51dnhqFzISUdKc6Tj4RBvQvnQkSubneWFZLQ=; b=Do8T5X9t7+rDxBdAzSuZ8cI2u5NWyCE/ajCIpCuxFECTqMvVEAkp49FtbBulrIC/QY09Hq 2/GMaFcJS6esdGOfBbu85Mawkix1/ky0HkLBVKUnGlNervWSNhC5NudBF3aKEQZHTwx7nR T/pizcI+3/NXZkl+YfRgT6+Nk4+RAhk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757504471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nukXpjG51dnhqFzISUdKc6Tj4RBvQvnQkSubneWFZLQ=; b=OMvVrlQAkYHnriEewU/AgB6bH84erNrd6ikz93vPIegO68SWH9X+dXWo2++n+uNNhAjbqk 0nEw2QePrW1l90DA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757504471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nukXpjG51dnhqFzISUdKc6Tj4RBvQvnQkSubneWFZLQ=; b=Do8T5X9t7+rDxBdAzSuZ8cI2u5NWyCE/ajCIpCuxFECTqMvVEAkp49FtbBulrIC/QY09Hq 2/GMaFcJS6esdGOfBbu85Mawkix1/ky0HkLBVKUnGlNervWSNhC5NudBF3aKEQZHTwx7nR T/pizcI+3/NXZkl+YfRgT6+Nk4+RAhk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757504471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nukXpjG51dnhqFzISUdKc6Tj4RBvQvnQkSubneWFZLQ=; b=OMvVrlQAkYHnriEewU/AgB6bH84erNrd6ikz93vPIegO68SWH9X+dXWo2++n+uNNhAjbqk 0nEw2QePrW1l90DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1208C13310; Wed, 10 Sep 2025 11:41:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vKBkA9djwWjhagAAD6G6ig (envelope-from ); Wed, 10 Sep 2025 11:41:11 +0000 Message-ID: <22b03d52-76c8-4ac6-96cf-830ec88eaef4@suse.de> Date: Wed, 10 Sep 2025 13:41:10 +0200 Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] md: init queue_limits->max_hw_wzeroes_unmap_sectors parameter To: Zhang Yi , linux-block@vger.kernel.org, linux-raid@vger.kernel.org, drbd-dev@lists.linbit.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, john.g.garry@oracle.com, pmenzel@molgen.mpg.de, hch@lst.de, martin.petersen@oracle.com, axboe@kernel.dk, yi.zhang@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com References: <20250910111107.3247530-1-yi.zhang@huaweicloud.com> <20250910111107.3247530-2-yi.zhang@huaweicloud.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250910111107.3247530-2-yi.zhang@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[oracle.com:email,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -4.30 On 9/10/25 13:11, Zhang Yi wrote: > From: Zhang Yi > > The parameter max_hw_wzeroes_unmap_sectors in queue_limits should be > equal to max_write_zeroes_sectors if it is set to a non-zero value. > However, the stacked md drivers call md_init_stacking_limits() to > initialize this parameter to UINT_MAX but only adjust > max_write_zeroes_sectors when setting limits. Therefore, this > discrepancy triggers a value check failure in blk_validate_limits(). > > $ modprobe scsi_debug num_parts=2 dev_size_mb=8 lbprz=1 lbpws=1 > $ mdadm --create /dev/md0 --level=0 --raid-device=2 /dev/sda1 /dev/sda2 > mdadm: Defaulting to version 1.2 metadata > mdadm: RUN_ARRAY failed: Invalid argument > > Fix this failure by explicitly setting max_hw_wzeroes_unmap_sectors to > max_write_zeroes_sectors. Since the linear and raid0 drivers support > write zeroes, so they can support unmap write zeroes operation if all of > the backend devices support it. However, the raid1/10/5 drivers don't > support write zeroes, so we have to set it to zero. > > Fixes: 0c40d7cb5ef3 ("block: introduce max_{hw|user}_wzeroes_unmap_sectors to queue limits") > Reported-by: John Garry > Closes: https://lore.kernel.org/linux-block/803a2183-a0bb-4b7a-92f1-afc5097630d2@oracle.com/ > Signed-off-by: Zhang Yi > Tested-by: John Garry > Reviewed-by: Li Nan > Reviewed-by: Martin K. Petersen > Reviewed-by: Yu Kuai > --- > drivers/md/md-linear.c | 1 + > drivers/md/raid0.c | 1 + > drivers/md/raid1.c | 1 + > drivers/md/raid10.c | 1 + > drivers/md/raid5.c | 1 + > 5 files changed, 5 insertions(+) > Notice the failure, too. Thanks for fixing it. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich