From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Xiao Ni <xni@redhat.com>, song@kernel.org
Cc: ncroxon@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/2] md: Move alloc/free acct bioset in to personality
Date: Fri, 10 Dec 2021 09:30:48 +0800 [thread overview]
Message-ID: <271afe73-b75c-0106-7906-11a40ca1a9dc@linux.dev> (raw)
In-Reply-To: <1639029324-4026-3-git-send-email-xni@redhat.com>
On 12/9/21 1:55 PM, Xiao Ni wrote:
> Now it alloc acct bioset in md_run and only raid0/raid5 need acct
> bioset. For example, it doesn't create acct bioset when creating
> raid1. Then reshape from raid1 to raid0/raid5, it will access acct
> bioset after reshaping. It can panic because of NULL pointer
> reference.
Thanks, I think the previous commit didn't think of the reshape scenario.
Could you paste the relevant info into commit header?
> We can move alloc/free jobs to personality. pers->run alloc acct
> bioset and pers->clean free it.
In the reshape case, the caller of pers->run is level_store, so.
Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Thanks,
Guoqing
next prev parent reply other threads:[~2021-12-10 1:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 5:55 [PATCH 0/2] md: it panic after reshape from raid1 to raid5 Xiao Ni
2021-12-09 5:55 ` [PATCH 1/2] md/raid0: Free r0conf memory when register integrity failed Xiao Ni
2021-12-09 18:02 ` Song Liu
2021-12-10 1:18 ` Xiao Ni
2021-12-10 2:07 ` Guoqing Jiang
2021-12-10 2:17 ` Xiao Ni
2021-12-10 2:27 ` Song Liu
2021-12-10 1:22 ` Guoqing Jiang
2021-12-10 1:34 ` Xiao Ni
2021-12-10 1:43 ` Guoqing Jiang
2021-12-10 2:29 ` Song Liu
2021-12-10 1:51 ` Xiao Ni
2021-12-09 5:55 ` [PATCH 2/2] md: Move alloc/free acct bioset in to personality Xiao Ni
2021-12-10 1:30 ` Guoqing Jiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-10 9:31 [PATCH 0/2] md: it panice after reshape from raid1 to raid5 Xiao Ni
2021-12-10 9:31 ` [PATCH 2/2] md: Move alloc/free acct bioset in to personality Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271afe73-b75c-0106-7906-11a40ca1a9dc@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).