From: Milan Broz <gmazyland@gmail.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>, Milan Broz <gmazyland@gmail.com>
Cc: Binoy Jayan <binoy.jayan@linaro.org>,
Rajendra <rnayak@codeaurora.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Oded <oded.golombek@arm.com>, Mike Snitzer <snitzer@redhat.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Ondrej Mosnacek <omosnace@redhat.com>,
linux-raid@vger.kernel.org, dm-devel@redhat.com,
Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, Shaohua Li <shli@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alasdair Kergon <agk@redhat.com>, Ofir <Ofir.Drang@arm.com>
Subject: Re: [RFC PATCH v4] IV Generation algorithms for dm-crypt
Date: Wed, 1 Mar 2017 14:04:47 +0100 [thread overview]
Message-ID: <2aef6e54-805f-e09b-ae66-c198f8c05335@gmail.com> (raw)
In-Reply-To: <CAOtvUMePYT7OJDKL7i0y3y6Jvqsxyx6Je6g9aGKVq6PLZ_-Z8w@mail.gmail.com>
On 03/01/2017 01:42 PM, Gilad Ben-Yossef wrote:
...
> I can certainly understand if you don't wont to take the patch until
> we have results with
> dm-crypt itself but the difference between 8 separate invocation of
> the engine for 512
> bytes of XTS and a single invocation for 4KB are pretty big.
Yes, I know it. But the same can be achieved if we just implement
4k sector encryption in dmcrypt. It is incompatible with LUKS1
(but next LUKS version will support it) but I think this is not
a problem for now.
If the underlying device supports atomic write of 4k sectors, then
there should not be a problem.
This is one of the speed-up I would like to compare with the IV approach,
because everyone should benefit from 4k sectors in the end.
And no crypto API changes are needed here.
(I have an old patch for this, so I will try to revive it.)
Milan
next prev parent reply other threads:[~2017-03-01 13:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 10:35 [RFC PATCH v4] IV Generation algorithms for dm-crypt Binoy Jayan
2017-02-07 10:35 ` [RFC PATCH v4] crypto: Add IV generation algorithms Binoy Jayan
2017-02-08 7:32 ` [RFC PATCH v4] IV Generation algorithms for dm-crypt Gilad Ben-Yossef
2017-02-09 8:30 ` Binoy Jayan
2017-02-22 6:12 ` Binoy Jayan
2017-02-28 21:05 ` Milan Broz
2017-03-01 8:30 ` Gilad Ben-Yossef
2017-03-01 9:29 ` Milan Broz
2017-03-01 12:42 ` Gilad Ben-Yossef
2017-03-01 13:04 ` Milan Broz [this message]
2017-03-01 15:38 ` Milan Broz
2017-03-06 14:38 ` Gilad Ben-Yossef
2017-03-20 14:31 ` Binoy Jayan
2017-03-20 14:38 ` Binoy Jayan
2017-03-01 13:21 ` Ondrej Mosnacek
2017-03-02 14:01 ` Gilad Ben-Yossef
2017-03-01 18:04 ` Binoy Jayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aef6e54-805f-e09b-ae66-c198f8c05335@gmail.com \
--to=gmazyland@gmail.com \
--cc=Ofir.Drang@arm.com \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=oded.golombek@arm.com \
--cc=omosnace@redhat.com \
--cc=rnayak@codeaurora.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).