* [PATCH 1/1] Remove the legacy whitespace
@ 2020-02-11 13:38 Xiao Ni
2020-02-11 13:41 ` Xiao Ni
0 siblings, 1 reply; 4+ messages in thread
From: Xiao Ni @ 2020-02-11 13:38 UTC (permalink / raw)
To: jes.sorensen; +Cc: ptoscano, ncroxon, linux-raid
The whitespace between Environment= and the true value causes confusion.
To avoid confusing other people in future, remove the whitespace to keep
it a simple, unambiguous syntax
Signed-off-by: Xiao Ni <xni@redhat.com>
---
systemd/mdcheck_continue.service | 2 +-
systemd/mdcheck_start.service | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service
index aa02dde..854317f 100644
--- a/systemd/mdcheck_continue.service
+++ b/systemd/mdcheck_continue.service
@@ -11,7 +11,7 @@ ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_*
[Service]
Type=oneshot
-Environment= "MDADM_CHECK_DURATION=6 hours"
+Environment="MDADM_CHECK_DURATION=6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}
diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service
index da62d5f..3bb3d13 100644
--- a/systemd/mdcheck_start.service
+++ b/systemd/mdcheck_start.service
@@ -11,7 +11,7 @@ Wants=mdcheck_continue.timer
[Service]
Type=oneshot
-Environment= "MDADM_CHECK_DURATION=6 hours"
+Environment="MDADM_CHECK_DURATION=6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Remove the legacy whitespace
2020-02-11 13:38 Xiao Ni
@ 2020-02-11 13:41 ` Xiao Ni
0 siblings, 0 replies; 4+ messages in thread
From: Xiao Ni @ 2020-02-11 13:41 UTC (permalink / raw)
To: jes.sorensen; +Cc: ptoscano, ncroxon, linux-raid
Hi all
Please ignore this patch. I missed another place that needs to modify. I'll
send a new patch later.
Regards
Xiao
On 02/11/2020 09:38 PM, Xiao Ni wrote:
> The whitespace between Environment= and the true value causes confusion.
> To avoid confusing other people in future, remove the whitespace to keep
> it a simple, unambiguous syntax
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> systemd/mdcheck_continue.service | 2 +-
> systemd/mdcheck_start.service | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service
> index aa02dde..854317f 100644
> --- a/systemd/mdcheck_continue.service
> +++ b/systemd/mdcheck_continue.service
> @@ -11,7 +11,7 @@ ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_*
>
> [Service]
> Type=oneshot
> -Environment= "MDADM_CHECK_DURATION=6 hours"
> +Environment="MDADM_CHECK_DURATION=6 hours"
> EnvironmentFile=-/run/sysconfig/mdadm
> ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
> ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}
> diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service
> index da62d5f..3bb3d13 100644
> --- a/systemd/mdcheck_start.service
> +++ b/systemd/mdcheck_start.service
> @@ -11,7 +11,7 @@ Wants=mdcheck_continue.timer
>
> [Service]
> Type=oneshot
> -Environment= "MDADM_CHECK_DURATION=6 hours"
> +Environment="MDADM_CHECK_DURATION=6 hours"
> EnvironmentFile=-/run/sysconfig/mdadm
> ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
> ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] Remove the legacy whitespace
@ 2020-02-11 13:44 Xiao Ni
2020-02-24 21:06 ` Jes Sorensen
0 siblings, 1 reply; 4+ messages in thread
From: Xiao Ni @ 2020-02-11 13:44 UTC (permalink / raw)
To: jes.sorensen; +Cc: ptoscano, ncroxon, linux-raid
The whitespace between Environment= and the true value causes confusion.
To avoid confusing other people in future, remove the whitespace to keep
it a simple, unambiguous syntax
Signed-off-by: Xiao Ni <xni@redhat.com>
---
systemd/mdcheck_continue.service | 2 +-
systemd/mdcheck_start.service | 2 +-
systemd/mdmonitor-oneshot.service | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service
index aa02dde..854317f 100644
--- a/systemd/mdcheck_continue.service
+++ b/systemd/mdcheck_continue.service
@@ -11,7 +11,7 @@ ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_*
[Service]
Type=oneshot
-Environment= "MDADM_CHECK_DURATION=6 hours"
+Environment="MDADM_CHECK_DURATION=6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}
diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service
index da62d5f..3bb3d13 100644
--- a/systemd/mdcheck_start.service
+++ b/systemd/mdcheck_start.service
@@ -11,7 +11,7 @@ Wants=mdcheck_continue.timer
[Service]
Type=oneshot
-Environment= "MDADM_CHECK_DURATION=6 hours"
+Environment="MDADM_CHECK_DURATION=6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}
diff --git a/systemd/mdmonitor-oneshot.service b/systemd/mdmonitor-oneshot.service
index fd469b1..373955a 100644
--- a/systemd/mdmonitor-oneshot.service
+++ b/systemd/mdmonitor-oneshot.service
@@ -9,7 +9,7 @@
Description=Reminder for degraded MD arrays
[Service]
-Environment= MDADM_MONITOR_ARGS=--scan
+Environment=MDADM_MONITOR_ARGS=--scan
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=BINDIR/mdadm --monitor --oneshot $MDADM_MONITOR_ARGS
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Remove the legacy whitespace
2020-02-11 13:44 [PATCH 1/1] Remove the legacy whitespace Xiao Ni
@ 2020-02-24 21:06 ` Jes Sorensen
0 siblings, 0 replies; 4+ messages in thread
From: Jes Sorensen @ 2020-02-24 21:06 UTC (permalink / raw)
To: Xiao Ni; +Cc: ptoscano, ncroxon, linux-raid
On 2/11/20 8:44 AM, Xiao Ni wrote:
> The whitespace between Environment= and the true value causes confusion.
> To avoid confusing other people in future, remove the whitespace to keep
> it a simple, unambiguous syntax
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-11 13:44 [PATCH 1/1] Remove the legacy whitespace Xiao Ni
2020-02-24 21:06 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2020-02-11 13:38 Xiao Ni
2020-02-11 13:41 ` Xiao Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).