linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: linan666@huaweicloud.com, song@kernel.org, neil@brown.name,
	namhyung@gmail.com
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	yangerkun@huawei.com, yi.zhang@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 5/7] md/raid10: fix any_working flag handling in raid10_sync_request
Date: Thu, 25 Sep 2025 17:01:56 +0800	[thread overview]
Message-ID: <2d94765c-219b-75f5-30fa-79a7324ba525@huaweicloud.com> (raw)
In-Reply-To: <20250917093508.456790-6-linan666@huaweicloud.com>

在 2025/09/17 17:35, linan666@huaweicloud.com 写道:
> From: Li Nan<linan122@huawei.com>
> 
> In raid10_sync_request(), 'any_working' indicates if any IO will
> be submitted. When there's only one In_sync disk with badblocks,
> 'any_working' might be set to 1 but no IO is submitted. Fix it by
> setting 'any_working' after badblock checks.
> 
> Fixes: e875ecea266a ("md/raid10 record bad blocks as needed during recovery.")
> Signed-off-by: Li Nan<linan122@huawei.com>
> ---
>   drivers/md/raid10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

LGTM
Reviewed-by: Yu Kuai <yukuai3@huawei.com>


  reply	other threads:[~2025-09-25  9:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  9:35 [PATCH 0/7] cleanup and bugfix of sync linan666
2025-09-17  9:35 ` [PATCH 1/7] md: factor error handling out of md_done_sync into helper linan666
2025-09-22  1:24   ` Yu Kuai
2025-09-17  9:35 ` [PATCH 2/7] md: mark rdev Faulty when badblocks setting fails linan666
2025-09-22  2:01   ` Li Nan
2025-09-17  9:35 ` [PATCH 3/7] md: cleanup MD_RECOVERY_ERROR flag linan666
2025-09-25  8:50   ` Yu Kuai
2025-09-17  9:35 ` [PATCH 4/7] md: factor out sync completion update into helper linan666
2025-09-25  9:00   ` Yu Kuai
2025-09-17  9:35 ` [PATCH 5/7] md/raid10: fix any_working flag handling in raid10_sync_request linan666
2025-09-25  9:01   ` Yu Kuai [this message]
2025-09-17  9:35 ` [PATCH 6/7] md/raid10: cleanup skip " linan666
2025-09-17  9:35 ` [PATCH 7/7] md: remove recovery_disabled linan666

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d94765c-219b-75f5-30fa-79a7324ba525@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=linan666@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=neil@brown.name \
    --cc=song@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).