public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Hochholdinger <Markus@hochholdinger.net>
To: Song Liu <song@kernel.org>
Cc: linux-raid <linux-raid@vger.kernel.org>, Xiao Ni <xni@redhat.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v2] md: fix update super 1.0 on rdev size change
Date: Wed, 17 Nov 2021 11:20:59 +0100	[thread overview]
Message-ID: <3087286.Pd3bozeLmo@enterprise> (raw)
In-Reply-To: <CAPhsuW4zBGnKAV_TWaZ78NVEhOUw61xYYKda1c33YB=JtAfChA@mail.gmail.com>

Am Mittwoch, 17. November 2021, 08:17:21 CET schrieb Song Liu:
> On Tue, Nov 16, 2021 at 2:22 AM Markus Hochholdinger
> <markus@hochholdinger.net> wrote:
> > The superblock of version 1.0 doesn't get moved to the new position on a
> > device size change. This leads to a rdev without a superblock on a known
> > position, the raid can't be re-assembled.
> > The line was removed by mistake and is re-added by this patch.
> > Fixes: d9c0fa509eaf ("md: fix max sectors calculation for super 1.0")
> > Signed-off-by: Markus Hochholdinger <markus@hochholdinger.net>
> > Reviewd-by: Xiao Ni <xni@redhat.com>
> Applied to md-fixes. Thanks!

Many thanks.

> This version still has some minor issues. I fixed them before applying. For
> future patches, please run ./scripts/checkpatch.pl on the .patch file.

OK, I wasn't aware of that, will do that check the next time.

Regards,
Markus



      reply	other threads:[~2021-11-17 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 10:21 [PATCH v2] md: fix update super 1.0 on rdev size change Markus Hochholdinger
2021-11-17  7:17 ` Song Liu
2021-11-17 10:20   ` Markus Hochholdinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3087286.Pd3bozeLmo@enterprise \
    --to=markus@hochholdinger.net \
    --cc=linux-raid@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox