From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E184EB64D7 for ; Fri, 23 Jun 2023 12:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbjFWMvt (ORCPT ); Fri, 23 Jun 2023 08:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbjFWMvh (ORCPT ); Fri, 23 Jun 2023 08:51:37 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF151FE3 for ; Fri, 23 Jun 2023 05:50:51 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-66872dbc2efso106264b3a.0 for ; Fri, 23 Jun 2023 05:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687524651; x=1690116651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3J6qedKH7rACUI+d8+QjoI1iru+7/a5M9lap7RdXq+s=; b=Q524DUGT6itGV4gw01qJj/zWbJLa4vy2WCXqnWOngK0C3q+dq5EKhIS0CVZv0oxxho LJ6tY9YfoIHNM/tflF8trZPv/Spx8OYgEAYGDhp6iajWSx+dfQpGCxtVSU4j+uchKR2K 6jjaYk2avrTfJwxxTgNPxH+prD4PA2RYda//8FNhgDDbtNG8gCEmPUtJ+VXKPa4DXVej a5KLbc1PmFNVMjg9t+MjU8GHA1HEy3OLaOZU0A/n71b/fjkikDpbyETS6JPqwOfw6qlc 81KayU6/lII4/pSrE7vPjFTNx81tmGljnxk2j498q4g7qxCoplXlCdPQ4N13nBnNs8tt 8JpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687524651; x=1690116651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3J6qedKH7rACUI+d8+QjoI1iru+7/a5M9lap7RdXq+s=; b=aU0xM9MO6nUQozPbdymU8OoeDranjAMm2tkzWrKvExgk4oUFzRXK8Q5w6RwMktbGjf 0wXOoPea7F3MwLBgje1/de8bLT5tx61g5nBPAhYYTzz58d+xMajvsb8HzGen8AbiVkIs aKeypRjRDonDgFmzdNY5oD28ruWRrPaJgNBubkI9N7TF6Y/m/lizMTltanRRuQAdgHTm Qy9zLvDMn4BZaLhT+O6ZPU+w4Vto0eXxEfPHwgxRAwav7Rv/z4D3UjHPtkcaztGeAAZd ywVEA/fMuIOuy5TlaEhydXAlAkXqqaJYKc7zigyPkV29Qtk6TSyHkIHw+o0oA+bXjX6W 6MmQ== X-Gm-Message-State: AC+VfDwbrt/6NfdE1ERAzTJX9DPxEKSQ4TlDtR+c1Wntvsbz2Bs4zHis 8n/hcpJXrrJa8Nfw+PfactBriw== X-Google-Smtp-Source: ACHHUZ6Fjrszr4MOiG7PTx+CVGVeY59XJZwzJifNOvY5NLzJaatECslqahuGwHQe8HJSyn0Dmf/QQQ== X-Received: by 2002:a05:6a00:3186:b0:668:7fe6:c220 with SMTP id bj6-20020a056a00318600b006687fe6c220mr14325912pfb.3.1687524651198; Fri, 23 Jun 2023 05:50:51 -0700 (PDT) Received: from [10.4.168.167] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id x21-20020aa79195000000b0063a04905379sm6063171pfa.137.2023.06.23.05.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:50:50 -0700 (PDT) Message-ID: <31d3f685-3017-25d8-5b0b-2795ed7049bc@bytedance.com> Date: Fri, 23 Jun 2023 20:50:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [External] Re: [PATCH 01/29] mm: shrinker: add shrinker::private_data field Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-2-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org Hi Vlastimil, On 2023/6/22 22:47, Vlastimil Babka wrote: > On 6/22/23 10:53, Qi Zheng wrote: >> To prepare for the dynamic allocation of shrinker instances >> embedded in other structures, add a private_data field to >> struct shrinker, so that we can use shrinker::private_data >> to record and get the original embedded structure. >> >> Signed-off-by: Qi Zheng > > I would fold this to 02/29, less churn. OK, I will fold this to 02/29 in the v2. Thanks, Qi > >> --- >> include/linux/shrinker.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >> index 224293b2dd06..43e6fcabbf51 100644 >> --- a/include/linux/shrinker.h >> +++ b/include/linux/shrinker.h >> @@ -70,6 +70,8 @@ struct shrinker { >> int seeks; /* seeks to recreate an obj */ >> unsigned flags; >> >> + void *private_data; >> + >> /* These are for internal use */ >> struct list_head list; >> #ifdef CONFIG_MEMCG >