From: Li Nan <linan666@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
Zheng Qixing <zhengqixing@huaweicloud.com>,
axboe@kernel.dk, song@kernel.org, colyli@kernel.org,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, dlemoal@kernel.org,
yanjun.zhu@linux.dev, kch@nvidia.com, hare@suse.de,
zhengqixing@huawei.com, john.g.garry@oracle.com,
geliang@kernel.org, xni@redhat.com, colyli@suse.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 04/12] badblocks: return error directly when setting badblocks exceeds 512
Date: Tue, 25 Feb 2025 17:13:26 +0800 [thread overview]
Message-ID: <366d8fee-e39e-bb01-db91-ecf359591ea5@huaweicloud.com> (raw)
In-Reply-To: <bec8776a-f0d4-2ec3-4455-9976ad87775e@huaweicloud.com>
在 2025/2/21 17:55, Yu Kuai 写道:
> Hi,
>
> +CC Linan
>
> 在 2025/02/21 16:11, Zheng Qixing 写道:
>> From: Li Nan <linan122@huawei.com>
>>
>> In the current handling of badblocks settings, a lot of processing has
>> been done for scenarios where the number of badblocks exceeds 512.
>> This makes the code look quite complex and also introduces some issues,
>
> It's better to add explanations about these issues here.
>>
Thank you for your review. I will add more details in the next version.
--
Thanks,
Nan
next prev parent reply other threads:[~2025-02-25 9:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 8:10 [PATCH 00/12] badblocks: bugfix and cleanup for badblocks Zheng Qixing
2025-02-21 8:10 ` [PATCH 01/12] badblocks: Fix error shitf ops Zheng Qixing
2025-02-21 9:05 ` Yu Kuai
2025-02-21 9:58 ` Coly Li
2025-02-21 8:10 ` [PATCH 02/12] badblocks: factor out a helper try_adjacent_combine Zheng Qixing
2025-02-21 9:07 ` Yu Kuai
2025-02-21 10:04 ` Coly Li
2025-02-21 10:06 ` Coly Li
2025-02-21 8:11 ` [PATCH 03/12] badblocks: attempt to merge adjacent badblocks during ack_all_badblocks Zheng Qixing
2025-02-21 9:12 ` Yu Kuai
2025-02-21 10:08 ` Coly Li
2025-02-21 8:11 ` [PATCH 04/12] badblocks: return error directly when setting badblocks exceeds 512 Zheng Qixing
2025-02-21 9:55 ` Yu Kuai
2025-02-25 9:13 ` Li Nan [this message]
2025-02-21 8:11 ` [PATCH 05/12] badblocks: return error if any badblock set fails Zheng Qixing
2025-02-21 9:52 ` Coly Li
2025-02-21 10:09 ` Yu Kuai
2025-02-21 10:12 ` Coly Li
2025-02-22 1:12 ` Yu Kuai
2025-02-22 6:16 ` Coly Li
2025-02-25 9:12 ` Li Nan
2025-02-22 6:18 ` Coly Li
2025-02-21 8:11 ` [PATCH 06/12] badblocks: fix the using of MAX_BADBLOCKS Zheng Qixing
2025-02-21 10:09 ` Zhu Yanjun
2025-02-25 9:14 ` Li Nan
2025-02-21 10:22 ` Coly Li
2025-02-22 1:15 ` Yu Kuai
2025-02-21 8:11 ` [PATCH 07/12] badblocks: try can_merge_front before overlap_front Zheng Qixing
2025-02-22 1:14 ` Yu Kuai
2025-02-21 8:11 ` [PATCH 08/12] badblocks: fix merge issue when new badblocks align with pre+1 Zheng Qixing
2025-02-22 1:21 ` Yu Kuai
2025-02-21 8:11 ` [PATCH 09/12] badblocks: fix missing bad blocks on retry in _badblocks_check() Zheng Qixing
2025-02-21 10:27 ` Coly Li
2025-02-22 1:28 ` Yu Kuai
2025-02-21 8:11 ` [PATCH 10/12] badblocks: return boolen from badblocks_set() and badblocks_clear() Zheng Qixing
2025-02-22 1:26 ` Yu Kuai
2025-02-22 4:32 ` Paul Menzel
2025-02-22 4:36 ` Paul Menzel
2025-02-22 6:20 ` Coly Li
2025-02-21 8:11 ` [PATCH 11/12] md: improve return types of badblocks handling functions Zheng Qixing
2025-02-22 1:27 ` Yu Kuai
2025-02-21 8:11 ` [PATCH 12/12] badblocks: use sector_t instead of int to avoid truncation of badblocks length Zheng Qixing
2025-02-21 10:37 ` Coly Li
2025-02-22 1:43 ` Yu Kuai
2025-02-21 9:00 ` [PATCH 00/12] badblocks: bugfix and cleanup for badblocks Yu Kuai
2025-02-21 11:52 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=366d8fee-e39e-bb01-db91-ecf359591ea5@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=colyli@kernel.org \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dlemoal@kernel.org \
--cc=geliang@kernel.org \
--cc=hare@suse.de \
--cc=ira.weiny@intel.com \
--cc=john.g.garry@oracle.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=song@kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yanjun.zhu@linux.dev \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
--cc=zhengqixing@huawei.com \
--cc=zhengqixing@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox