Re: [PATCH 2/2] md: bypass block throttle for superblock update

[junxiao.bi@oracle.com]

On 11/7/23 11:33 AM, Logan Gunthorpe wrote:

>
> On 2023-11-07 10:57, Junxiao Bi wrote:
>> commit 5e2cf333b7bd ("md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d")
>> introduced a hung bug and got reverted in last patch, since the issue
>> that commit is fixing is due to md superblock write is throttled by wbt,
>> to fix it, we can have superblock write bypass block layer throttle.
>>
>> Fixes: 5e2cf333b7bd ("md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d")
>> Suggested-by: Yu Kuai <yukuai1@huaweicloud.com>
>> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> This makes sense to me. However, I haven't looked at that bug in a long
> time though and I haven't tested the proposed solution to ensure the bug
> is indeed fixed.
>
> Would it not make sense to have the fixing commit first before the
> revert? So there isn't a spot in the history with a known bug?

Yea, that makes sense.

Thanks for the review.

>
> Besides that,
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>
> Thanks!
>
> Logan