From: "Kevin P. Fleming" <kpfleming@cox.net>
To: linux-raid@vger.kernel.org
Subject: Re: [PATCH] 2.4.18-26.7.x /proc/mdstat seq_file
Date: Wed, 12 Mar 2003 18:53:23 -0700 [thread overview]
Message-ID: <3E6FE493.4010601@cox.net> (raw)
In-Reply-To: <15983.55499.207149.314602@notabene.cse.unsw.edu.au>
Neil Brown wrote:
> On Tuesday March 11, ARechenberg@shermanfinancialgroup.com wrote:
>
>>With Kevin's patch from last week and some help from Randy, I patched
>>the md code in Red Hat 2.4.18-26.7.x to use the seq_file interface for
>>mdstat. I've attached the patch. As with Kevin's patch, it touches
>>almost everything in drivers/md, as well as adding the necessary methods
>>to fs/seq_file.c and include/linux/seq_file.h.
>
>
> While this patch quite possibly works, I think it misses the point of
> seq_file.
>
> seq_file allows you to return the content of a possibly-large file in
> lots of little bits, so multiple 'read' calls on the file don't
> iterrate over the whole file every time.
>
> I recently sent a patch to Linus for 2.5 that converts /proc/mdstat to
> use seq_file using what I understand to be the intended approach, and
> I have just posted as similar patch for 2.4 to Marcelo. I expect it
> appeared on linux-raid before you saw this...
>
Yep, saw it, it's most definitely a better solution. My solution was
quick and dirty, only get it to stop oopsing (and so I could actually
monitor my arrays).
prev parent reply other threads:[~2003-03-13 1:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-11 20:56 [PATCH] 2.4.18-26.7.x /proc/mdstat seq_file Rechenberg, Andrew
2003-03-13 1:03 ` Neil Brown
2003-03-13 1:53 ` Kevin P. Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E6FE493.4010601@cox.net \
--to=kpfleming@cox.net \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).