From: Paul Clements <Paul.Clements@SteelEye.com>
To: sdake@mvista.com
Cc: linux-raid@vger.kernel.org
Subject: Re: Patch to fix defect in raid 1 spinlocks
Date: Fri, 12 Dec 2003 18:44:47 -0500 [thread overview]
Message-ID: <3FDA52EF.2E1C2767@SteelEye.com> (raw)
In-Reply-To: 1071270293.31245.47.camel@persist.az.mvista.com
Steven Dake wrote:
> The spinlock is located in the function raid1_alloc_bh. This function
> is called by raid1_make_request (spin_lock_irq is safe in this call
> path). It is also called by raid1d (spin_lock_irq is unsafe in this
> call path, and spin_lock_irqsave should be used instead).
Hi Steve,
I'm not sure this analysis is correct. raid1_alloc_bh has to reenable
interrupts before it allocates memory or goes to sleep, so
raid1_alloc_bh had better not be called with interrupts disabled. Also,
I don't believe raid1d would have interrupts disabled, given that it's a
kernel thread.
Thanks,
Paul
prev parent reply other threads:[~2003-12-12 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-12 23:04 Patch to fix defect in raid 1 spinlocks Steven Dake
2003-12-12 23:44 ` Paul Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FDA52EF.2E1C2767@SteelEye.com \
--to=paul.clements@steeleye.com \
--cc=linux-raid@vger.kernel.org \
--cc=sdake@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).