From: Mark Bellon <mbellon@mvista.com>
To: linux-raid@vger.kernel.org
Subject: 2.4.25 MD RAID 1 driver - memory leak?
Date: Tue, 23 Mar 2004 16:14:37 -0700 [thread overview]
Message-ID: <4060C4DD.2070506@mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
If I'm reading things correctly I believe there is a memory leak in the
RAID 1 driver. A patch is attached for the fix.
The end_sync_read function forwards the read operation (r1_bh) that
completed by the raid1_reschedule_retry function. The r1_bh->cmd value
is SPECIAL. If the R1BH_Uptodate bit is not set a message is printed and
md_done_sync is called - but raid1_free_buf is not called. Look a few
lines above at the "!sum_bhs" case for comparison.
mark
[-- Attachment #2: raid1-patch --]
[-- Type: text/plain, Size: 282 bytes --]
--- raid1.c.orig 2004-03-23 16:09:48.000000000 -0700
+++ raid1.c 2004-03-23 16:09:18.000000000 -0700
@@ -1252,6 +1252,7 @@
printk (IO_ERROR, partition_name(bh->b_dev), bh->b_blocknr);
md_done_sync(mddev, bh->b_size>>9, 0);
+ raid1_free_buf(r1_bh);
}
break;
next reply other threads:[~2004-03-23 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-23 23:14 Mark Bellon [this message]
2004-03-24 16:09 ` 2.4.25 MD RAID 1 driver - syncing hung due to I/O error Mark Bellon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4060C4DD.2070506@mvista.com \
--to=mbellon@mvista.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).