From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B1E1A681B for ; Mon, 2 Mar 2026 21:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772485447; cv=none; b=UNHevy0gm919pJHjAdCGj0KSFex48ZmYc3peRdUgc74sKhzTV49t8F0MXRwlOp1YX6Uv1imKfLtuzIUiSUOM4HpSJCuOMADdDWPNGhZQgJILxzuJ9rXykpATN+TGj2+dHuOCKNpqjSVPrIGI6tC3dZBWqeIuHWmRrpXGky15QqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772485447; c=relaxed/simple; bh=UwKN828bpYjsATwe/PFNfBBgDEwwJJjZ3GciXwnOP1g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L4CI/dRwgsGF7x056EeFixNJwbk9oty0C5VE5I1OnlM3vIT0y9FSy96Vbbx12Hci7ggHkUpQf9MdTjgR+smyeQrXcDDY6rV4/20Atvwym0BGYh4p0I5Nm0AW8q/RKADtkVL4dXT4ON8wG0nYeibyZtjPZ3XLkVCRVhdNTPtGCo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=Z4Bzo0Wf; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="Z4Bzo0Wf" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-46392972257so4014366b6e.2 for ; Mon, 02 Mar 2026 13:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772485445; x=1773090245; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UvIDDVWC3amChzTdZaAU+7HRWfu0rMD4zIP/5WJSg4Y=; b=Z4Bzo0Wf3G+d2z5kyswDxW3jW+NPZDiVyYZwCcqN83Y49dvLqgm1fj0D+2nh2e/7HK y8XgjjOFWG50GRCh2srXXbYtnH1gxt5oudR0awiokKqFJBqFV+75vqF0fXZcb9O37PzB ssP/XV05YlZsYh2QLF+rBPyBu9kralV3P1u67TnrC4Gq176kdbtB+q+Yzk7rNrtA2DyL JNxO+m04ssNNgDdJS5SdTjn5rlUQGzbyEPyhUWsMrh4R0eemKB2xMgXYGgCtad/ThjyD pZvO5pkjXBF07tjJWmuzdzaOoLCD/n7CQeuwzhnCm1zeTQbegrjQte7JAmiotc4r7I1y akRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772485445; x=1773090245; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UvIDDVWC3amChzTdZaAU+7HRWfu0rMD4zIP/5WJSg4Y=; b=NyKEiZx70MVgS18XMUGZ3DjMc5Yy/LnHdsWhliL5hh8uXfIcuO8H6lnct6cMP/WZQz xNdWKmFHljbtgpY6eRoL1mA8uhXxmsolD0eNc2byLVGkHU0FZz9mDaN/N9sIWifOlojV Xt6FqTiQcMIZ7HnmKGeWED8uYEFVr49HpS3oZ8i0OwwqrJMFOkDlCcw8WEz+hogheZb6 1h0bG/yznv45Cjdphq0g5I6MG5//rje5li0Gyvw2T/5e7okotwiw8NCUy+f+ZBE9CLUq lKxuJM8wLCCXmHTvHRqqTuci60xt0q+IwGEXQK6hp9coOOu2OzIkaMirGnEfuS/aWMvc m6Fg== X-Forwarded-Encrypted: i=1; AJvYcCVzO02EMwMcjE4s7oTJbMkLEjngV6SH5KDLgAzHbvW8OVo6tnTJbG/j5kWxfsuTF2ktyFdkuw0tWYrf@vger.kernel.org X-Gm-Message-State: AOJu0Yz57VBeW77P8xP5ciy71lZd1uv5AK7YnXoDFCYMwQ9YewKy+scn tCJGM5ZnM3ZMADHptj2BQdvpK/dDU6UK9M9GgvpqbVDvAxYi4OrQevtU8Sdku/YLb64= X-Gm-Gg: ATEYQzytaH6/NyP7URuraRJ4FCiHxsE+teAQoEzzY1oOLqnwuPqexAIWnBUlByXjHME tLrArfpen2MiJpcKzJvEhn+fgDmF+GcpU1r+ACC+nsteV7nCC2RcNRQ7HP2FrCaWGGis75pE3uK 2fVScxEZThibVY4YIvpvulE7jh/Q/RBNUi/A8KRHanAGpmIBIMjcr5yBe6Pf3n7UIuu9CG9Yc2q UE64Hv4VWozETqSucrmOx74aMC/lRE/33y+zIp2saqKSg6Ouw464Q7/+XBko5bZMxVO5KN4/dzu 33uTu+0g+sMKusftrEiXqwMOI5+7qrVSAOjL46KzcnCTdMAf7DewWdZ+TYH5MaXv5iU3ADtsZ7A iUWAxexkGx8FNdou2U268JlRrqm8EquPPphhVj3D7RiUDK83czoBpGv1cr8GgC4svfS/Qx/31tr LvJf1WYNAm40SnahA7RREzpOMdKFBzoMlOuE1WT73DN5z+gRxM8zpF4C476MvpfSbFDYrbjEyln rb1OBf58OlvgiPqt4Cx X-Received: by 2002:a05:6808:8281:b0:463:b4bd:5287 with SMTP id 5614622812f47-464be921973mr6434178b6e.11.1772485444663; Mon, 02 Mar 2026 13:04:04 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 5614622812f47-464bb3ab302sm8292175b6e.7.2026.03.02.13.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 13:04:03 -0800 (PST) Message-ID: <40e13629-aa4c-45ba-a2da-b7614961def0@kernel.dk> Date: Mon, 2 Mar 2026 14:04:01 -0700 Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: remove bdev_nonrot() To: Damien Le Moal , Paul Menzel Cc: linux-block@vger.kernel.org, Song Liu , Yu Kuai , linux-raid@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, Theodore Ts'o , linux-ext4@vger.kernel.org, Andreas Dilger , Andrew Morton , Chris Li , Kairui Song , linux-mm@kvack.org References: <20260226075448.2229655-1-dlemoal@kernel.org> <5b8c1811-c9d9-469a-b8d0-992814a11b9a@molgen.mpg.de> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/26/26 5:27 AM, Damien Le Moal wrote: > > Is it worth the change, as it looks quite subjective if you prefer the >> one or the other way? > > I think it is a nice cleanup, but I will let Jens and other > maintainers decide on the worth of this patch. It's a bit of pointless churn, but I kind of suspected this was coming when we added the bdev_rot() helper and now had both of them. So I guess we may as well finish it, as we're half-way there anyway. -- Jens Axboe