linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Guanqin Miao <miaoguanqin@huawei.com>,
	mariusz.tkaczyk@linux.intel.com, pmenzel@molgen.mpg.de,
	linux-raid@vger.kernel.org
Cc: linfeilong@huawei.com, lixiaokeng@huawei.com, louhongxiang@huawei.com
Subject: Re: [PATCH 0/4] Fix memory leak for Manage Assemble Kill mdadm
Date: Fri, 1 Sep 2023 12:07:59 -0400	[thread overview]
Message-ID: <42664c9a-ba6c-e85b-731f-f217e24c8f2f@trained-monkey.org> (raw)
In-Reply-To: <bbafe9cc-dbd1-c503-c294-aec9dbd4dccb@trained-monkey.org>

On 9/1/23 12:02, Jes Sorensen wrote:
> On 4/24/23 04:06, Guanqin Miao wrote:
>> When we test mdadm with asan,i we found some memory leaks.
>> We fix these memory leaks based on code logic.
>>
>> Guanqin Miao (4):
>>   Fix memory leak in file Assemble
>>   Fix memory leak in file Kill
>>   Fix memory leak in file Manage
>>   Fix memory leak in file mdadm
>>
>>  Assemble.c | 13 +++++++++++--
>>  Kill.c     |  9 ++++++++-
>>  Manage.c   | 11 ++++++++++-
>>  mdadm.c    |  4 ++++
>>  4 files changed, 33 insertions(+), 4 deletions(-)
>>
> 
> I applied this, modulo a fix to the Manage fix, where it would try to
> call free(tst) in the abort path, before tst was initialized.

Oh and a fix to Assemble where free(st) would goto loop and then
dereference st.

Jes



  reply	other threads:[~2023-09-01 16:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  8:06 [PATCH 0/4] Fix memory leak for Manage Assemble Kill mdadm Guanqin Miao
2023-04-24  8:06 ` [PATCH 1/4] Fix memory leak in file Assemble Guanqin Miao
2023-08-23 13:43   ` Mariusz Tkaczyk
2023-04-24  8:06 ` [PATCH 2/4] Fix memory leak in file Kill Guanqin Miao
2023-08-23 13:49   ` Mariusz Tkaczyk
2023-04-24  8:06 ` [PATCH 3/4] Fix memory leak in file Manage Guanqin Miao
2023-08-23 13:50   ` Mariusz Tkaczyk
2023-04-24  8:06 ` [PATCH 4/4] Fix memory leak in file mdadm Guanqin Miao
2023-08-23 13:51   ` Mariusz Tkaczyk
2023-09-01 16:02 ` [PATCH 0/4] Fix memory leak for Manage Assemble Kill mdadm Jes Sorensen
2023-09-01 16:07   ` Jes Sorensen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-06 11:40 Guanqin Miao
2023-03-23  1:30 miaoguanqin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42664c9a-ba6c-e85b-731f-f217e24c8f2f@trained-monkey.org \
    --to=jes@trained-monkey.org \
    --cc=linfeilong@huawei.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=lixiaokeng@huawei.com \
    --cc=louhongxiang@huawei.com \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=miaoguanqin@huawei.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).