From: Paul Clements <paul.clements@steeleye.com>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 1/1] md: fix hot add for non-persistent superblock arrays
Date: Thu, 19 May 2005 20:44:00 -0400 [thread overview]
Message-ID: <428D32D0.1030104@steeleye.com> (raw)
In-Reply-To: <E1DWS99-00014N-En@notabene.cse.unsw.edu.au>
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
Neil,
hot add is not working for non-persistent superblock arrays (md is
trying, and failing, to read a superblock from the new disk)...
attached patch fixes it...
Thanks,
Paul
[-- Attachment #2: md_non_persistent_hot_add.diff --]
[-- Type: text/plain, Size: 742 bytes --]
Signed-Off-By: Paul Clements <paul.clements@steeleye.com>
md.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -purN --exclude-from /export/public/clemep/tmp/dontdiff linux-2.6.12-rc1-mm2-PRISTINE/drivers/md/md.c linux-2.6.12-rc1-mm2/drivers/md/md.c
--- linux-2.6.12-rc1-mm2-PRISTINE/drivers/md/md.c Fri Mar 25 14:33:36 2005
+++ linux-2.6.12-rc1-mm2/drivers/md/md.c Thu May 19 16:29:44 2005
@@ -2218,7 +2218,8 @@ static int add_new_disk(mddev_t * mddev,
mdname(mddev));
return -EINVAL;
}
- rdev = md_import_device(dev, mddev->major_version,
+ rdev = md_import_device(dev, mddev->persistent ?
+ mddev->major_version : -1,
mddev->minor_version);
if (IS_ERR(rdev)) {
printk(KERN_WARNING
next prev parent reply other threads:[~2005-05-20 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 4:51 [PATCH md 000 of 2] Introduction NeilBrown
2005-05-13 4:51 ` [PATCH md 001 of 2] Cause md/raid1 to "repack" working devices when number of drives is changed NeilBrown
2005-05-13 4:51 ` [PATCH md 002 of 2] Make sure recovery happens when add_new_disk is used for hot_add NeilBrown
2005-05-20 0:44 ` Paul Clements [this message]
2005-05-24 5:01 ` [PATCH 1/1] md: fix hot add for non-persistent superblock arrays Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428D32D0.1030104@steeleye.com \
--to=paul.clements@steeleye.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).