linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eyal Lebedinsky <eyal@eyal.emu.id.au>
To: Tyler <pml@dtbb.net>
Cc: linux-raid list <linux-raid@vger.kernel.org>
Subject: Re: Promise SATAII150 TX4 or raidreconf broken - answer
Date: Sun, 18 Sep 2005 19:56:04 +1000	[thread overview]
Message-ID: <432D39B4.5020709@eyal.emu.id.au> (raw)
In-Reply-To: <432D2BC6.50300@dtbb.net>

Tyler wrote:
> Eyal Lebedinsky wrote:
> 
>> Executive summary: it is not the TX4. It is not really raidreconf.
>> You must specify the parity-algorithm in raidtab because the
>> raidreconf default is not what one expects.
[trim]

> Nice work Eyal :)
> 
> Now all we need is a patch for raid-reconf to fix default behaviour? :D
> 
> Regards,
> Tyler.

Well, as simple as this looks, I have little understanding of what
goes on here. For example, looking at raidtools-1.00.3, I see this:

This is defined in three source files, as well as in common.h

# define RAID5_ALGORITHM_LEFT_SYMMETRIC        (2)

In prconv.c, readboth.c, rrc_raid5.c and sectors.c the algorithm
hard set:

static unsigned long
raid5_compute_block (... whatever ...)
{
        int algorithm = RAID5_ALGORITHM_LEFT_SYMMETRIC;
	...
	/* Select the parity disk based on the user selected algorithm */
	switch (algorithm) {

I cannot see how 'algorithm' can be altered at all here, so I do not
think that these programs respond to the raidtab algorithm at all.

In short, maybe raidreconf should not only default to left-symmetric
but refuse any other algorithm if it needs to cooperate with the other
programs here.

Better someone who knows this area does this. The actual setting
of a default is simple.

-- 
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
	attach .zip as .dat

      reply	other threads:[~2005-09-18  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <430E4AB0.2060600@eyal.emu.id.au>
     [not found] ` <4313E433.1080602@pobox.com>
2005-09-10  8:23   ` Promise SATAII150 TX4 or raidreconf broken Eyal Lebedinsky
     [not found]   ` <43223709.8090002@eyal.emu.id.au>
     [not found]     ` <x3kfysdq846.fsf@Psilocybe.Update.UU.SE>
2005-09-11 15:50       ` Eyal Lebedinsky
2005-09-12 22:50       ` Promise SATAII150 TX4 or raidreconf broken - answer Eyal Lebedinsky
2005-09-18  8:56         ` Tyler
2005-09-18  9:56           ` Eyal Lebedinsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432D39B4.5020709@eyal.emu.id.au \
    --to=eyal@eyal.emu.id.au \
    --cc=linux-raid@vger.kernel.org \
    --cc=pml@dtbb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).