From: Xiao Ni <xni@redhat.com>
To: Wols Lists <antlists@youngman.org.uk>,
linux-raid@vger.kernel.org, jes@trained-monkey.org
Cc: ncroxon@redhat.com, heinzm@redhat.com
Subject: Re: [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes
Date: Sun, 26 Jul 2020 21:44:01 +0800 [thread overview]
Message-ID: <4441f34e-0b04-afcb-8bf7-45d3d605d438@redhat.com> (raw)
In-Reply-To: <5F1D476C.4090605@youngman.org.uk>
On 07/26/2020 05:05 PM, Wols Lists wrote:
> On 23/07/20 12:20, Xiao Ni wrote:
>> Now it allow updating cluster nodes without specify --nodes. It can write superblock
>> with zero nodes. It can break the current cluster. Add this check to avoid this problem.
>>
>> v2: It needs check c.update first to void NULL pointer reference
> ^^^^
> Do you mean "avoid"?
Hi Wol
Yes. Thanks for pointing out the error. I'll re-send the patch
Regards
Xiao
prev parent reply other threads:[~2020-07-26 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 11:20 [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes Xiao Ni
2020-07-26 9:05 ` Wols Lists
2020-07-26 13:44 ` Xiao Ni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4441f34e-0b04-afcb-8bf7-45d3d605d438@redhat.com \
--to=xni@redhat.com \
--cc=antlists@youngman.org.uk \
--cc=heinzm@redhat.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).