From: Michael Tokarev <mjt@tls.msk.ru>
To: Neil Brown <neilb@suse.de>
Cc: Luca Berra <bluca@comedia.it>, linux-raid@vger.kernel.org
Subject: Re: problems with raid=noautodetect
Date: Mon, 29 May 2006 12:38:25 +0400 [thread overview]
Message-ID: <447AB301.6050107@tls.msk.ru> (raw)
In-Reply-To: <17530.30389.862288.268450@cse.unsw.edu.au>
Neil Brown wrote:
> On Friday May 26, bluca@comedia.it wrote:
[]
> If we assume there is a list of devices provided by a (possibly
> default) 'DEVICE' line, then
>
> DEVICEFILTER !pattern1 !pattern2 pattern3 pattern4
>
> could mean that any device in that list which matches pattern 1 or 2
> is immediately discarded, and remaining device that matches patterns 3
> or 4 are included, and the remainder are discard.
>
> The rule could be that the default is to include any devices that
> don't match a !pattern, unless there is a pattern without a '!', in
> which case the default is to reject non-accepted patterns.
> Is that straight forward enough, or do I need an
> order allow,deny
> like apache has?
I'd suggest the following.
"All the other devices" are included or excluded from the list of devices
to consider based on the last component in the DEVICE line. Ie. if it
ends up at !dev, all the rest of devices are included. If it ends up at
dev (w/o !), all the rest are excluded. If memory serves me right, it's
how squid ACLs works.
There's no need to introduce new keyword. Given this rule, a line
DEVICE a b c
will do exactly as it does now. Line
DEVICE a b c !d
is somewhat redundant - it's the same as DEVICE !d
Ie, if the list ends up at !stuff, append `partitions' (or *) to it.
Ofcourse mixing !s and !!s is useful, like to say use all sda* but not
sda1:
DEVICE !sda1 sda*
(and nothing else).
And the default is to have `DEVICE partitions'.
The only possible issue I see here is that with udev, it's possible to
use, say, /dev/disk/by-id/*-like stuff (don't remember exact directory
layout) -- symlinked to /dev/sd* according to the disk serial number or
something like that -- for this to work, mdadm needs to use glob()
internally.
/mjt
next prev parent reply other threads:[~2006-05-29 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 12:41 problems with raid=noautodetect Florian Dazinger
2006-05-22 22:39 ` Neil Brown
2006-05-24 12:47 ` problems with raid=noautodetect - solved Florian Dazinger
2006-05-26 0:10 ` Nix
2006-05-26 7:53 ` problems with raid=noautodetect Luca Berra
2006-05-26 7:56 ` Luca Berra
2006-05-29 4:21 ` Neil Brown
2006-05-29 5:02 ` Luca Berra
2006-05-29 8:38 ` Michael Tokarev [this message]
2006-05-29 8:54 ` Luca Berra
2006-05-30 17:10 ` Bill Davidsen
2006-05-30 17:30 ` Luca Berra
2006-05-31 13:23 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447AB301.6050107@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=bluca@comedia.it \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).