ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Neil Brown]

I am pleased to announce the availability of
   mdadm version 2.5.1

It is available at the usual places:
   http://www.cse.unsw.edu.au/~neilb/source/mdadm/
and
   http://www.${countrycode}kernel.org/pub/linux/utils/raid/mdadm/
and via git at
   git://neil.brown.name/git/mdadm

mdadm is a tool for creating, managing and monitoring
device arrays using the "md" driver in Linux, also
known as Software RAID arrays.

Release 2.5.1 adds multiple minor updates including a couple of bugfixes.

Changelog Entries:
    -   Various fixes for gcc warnings
    -   uclibc warnings
    -   Makefile improvements for static linking/intalling
    -   Makefile uninstall target
    -   Really fix return status of --examine
    -   Typos
    -   Byteorder stuff (again)
    -   Don't try to create devices with --manage or --grow
    -   allow default metadata (superblock) type to be specified
	in mdadm.conf
    -   Get --stop to list devices stopped but honour --quiet
    -   remove libssl dependency
    -   Avoid some misdetection of overlapping partitions
    -   Fix memory leak in --monitor mode

Development of mdadm is sponsored by
 SUSE Labs, Novell Inc.

NeilBrown  16th June 2006

Re: ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Paul Clements]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Neil Brown wrote:
> 
> I am pleased to announce the availability of
>    mdadm version 2.5.1

Hi Neil,

Here's a small patch to allow compilation on gcc 2.x. It looks like gcc 
3.x allows variable declarations that are not at the start of a block of 
code (I don't know if there's some standard that allows that in C code 
now, but it doesn't work with all C compilers).

Patch attached.

Thanks,
Paul

[-- Attachment #2: mdadm-2.5.1-super1-compile-error.diff --]
[-- Type: text/plain, Size: 563 bytes --]

--- mdadm-2.5.1/super1.c.orig	Fri Jun 16 11:27:16 2006
+++ mdadm-2.5.1/super1.c	Fri Jun 16 11:28:20 2006
@@ -309,6 +309,7 @@ static void brief_examine_super1(void *s
 	struct mdp_superblock_1 *sb = sbv;
 	int i;
 	char *nm;
+	char *c=map_num(pers, __le32_to_cpu(sb->level));
 
 	nm = strchr(sb->set_name, ':');
 	if (nm)
@@ -317,8 +318,6 @@ static void brief_examine_super1(void *s
 		nm = sb->set_name;
 	else
 		nm = "??";
-
-	char *c=map_num(pers, __le32_to_cpu(sb->level));
 
 	printf("ARRAY /dev/md/%s level=%s metadata=1 num-devices=%d UUID=",
 	       nm,

Re: ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Bill Davidsen]

Paul Clements wrote:

> Neil Brown wrote:
>
>>
>> I am pleased to announce the availability of
>>    mdadm version 2.5.1
>
>
> Hi Neil,
>
> Here's a small patch to allow compilation on gcc 2.x. It looks like 
> gcc 3.x allows variable declarations that are not at the start of a 
> block of code (I don't know if there's some standard that allows that 
> in C code now, but it doesn't work with all C compilers). 

Even if valid, having the declaration at the top of the block in which 
it's used makes the program more readable.

-- 
bill davidsen <davidsen@tmr.com>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979

mdadm 2.5.1 - A problem came up ...

[Mr. James W. Laferriere]

 	Hello Neil ,  If I add any disk partition to end of the below command as
 	man mdadm requests .  Ok ,  Now I get it ,  "partitions" or "none" are
 	required .  But still ...

 	<Quote>
 	mdadm --examine --brief --scan --config=partitions
 	mdadm -Ebsc partitions
 	Create  a list of devices by reading /proc/partitions, scan these for RAID superblocks, and printout a brief listing of all that was found.
 	<\Quote>

root@privateers:~# mdadm -Ebsc
mdadm: option requires an argument -- c
Usage: mdadm --help
   for help

 	Ok ,  But when I do a ...

root@privateers:~# mdadm -Ebsc --help
ARRAY /dev/md0 level=raid1 num-devices=2 UUID=8d5cd2c7:42544200:d2bdaaad:ce1bab0c
ARRAY /dev/md1 level=raid1 num-devices=2 UUID=e8a0caca:1e477715:f7f74d6b:88dd401c
ARRAY /dev/md3 level=raid1 num-devices=2 UUID=a87d5acf:17038a98:03577e48:76e31d5c
ARRAY /dev/md2 level=raid1 num-devices=2 UUID=8f4b56fa:840ad5eb:0c28a667:6a46f759

 	I was expecting a help readout not the command to actually function .
 		Hth ,  JimL
-- 
+----------------------------------------------------------------------+
| James   W.   Laferriere |   System    Techniques   | Give me VMS     |
| Network        Engineer | 3600 14th Ave SE #20-103 |  Give me Linux  |
| babydr@baby-dragons.com |  Olympia ,  WA.   98501  |   only  on  AXP |
+----------------------------------------------------------------------+

Re: mdadm 2.5.1 - A problem came up ...

[Neil Brown]

On Friday June 16, babydr@baby-dragons.com wrote:
>  	Hello Neil ,  If I add any disk partition to end of the below command as
>  	man mdadm requests .  Ok ,  Now I get it ,  "partitions" or "none" are
>  	required .  But still ...
> 
>  	<Quote>
>  	mdadm --examine --brief --scan --config=partitions
>  	mdadm -Ebsc partitions
>  	Create  a list of devices by reading /proc/partitions, scan these for RAID superblocks, and printout a brief listing of all that was found.
>  	<\Quote>
> 
> root@privateers:~# mdadm -Ebsc
> mdadm: option requires an argument -- c

Yes, it requires an argument.  The argument in I gave in the example
was 'partitions'.


> Usage: mdadm --help
>    for help
> 
>  	Ok ,  But when I do a ...
> 
> root@privateers:~# mdadm -Ebsc --help
> ARRAY /dev/md0 level=raid1 num-devices=2 UUID=8d5cd2c7:42544200:d2bdaaad:ce1bab0c
> ARRAY /dev/md1 level=raid1 num-devices=2 UUID=e8a0caca:1e477715:f7f74d6b:88dd401c
> ARRAY /dev/md3 level=raid1 num-devices=2 UUID=a87d5acf:17038a98:03577e48:76e31d5c
> ARRAY /dev/md2 level=raid1 num-devices=2 UUID=8f4b56fa:840ad5eb:0c28a667:6a46f759
> 
>  	I was expecting a help readout not the command to actually function .

Yes, maybe it should have complained that '--help' was not a valid
config file, which is what that command is suggesting.

Putting '--help' first leaves less room for confusion, not that it
would have helped much in this case. :-(

$ ./mdadm --help -Ebsc
./mdadm: option requires an argument -- c
Usage: mdadm --help
  for help


NeilBrown

Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Paul Clements]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Bill Davidsen wrote:
> Paul Clements wrote:
> 
>> Neil Brown wrote:
>>
>>>
>>> I am pleased to announce the availability of
>>>    mdadm version 2.5.1

and here's another patch for a compile error on ppc...

Since ppc is big endian, the compiler is complaining because it can't 
determine whether the isuper post-increment (++) is actually going to be 
evaluated (__le32_to_cpu is a macro). On x86 the macro is a no-op, so I 
guess the compiler is smart enough to figure out that the post-increment 
is actually happening?

Here's the warning (gcc 3.2.3):

$ make
gcc -Wall -Werror -Wstrict-prototypes -ggdb 
-DSendmail=\""/usr/sbin/sendmail -t"\" -DCONFFILE=\"/etc/mdadm.conf\" 
-DCONFFILE2=\"/etc/mdadm/mdadm.conf\"   -c -o super1.o super1.c
cc1: warnings being treated as errors
super1.c: In function `calc_sb_1_csum':
super1.c:128: warning: operation on `isuper' may be undefined
super1.c:128: warning: operation on `isuper' may be undefined
super1.c:128: warning: operation on `isuper' may be undefined
make: *** [super1.o] Error 1


Thanks,
Paul

[-- Attachment #2: mdadm-2.5.1-super1-compile-error-ppc.diff --]
[-- Type: text/plain, Size: 522 bytes --]

--- super1.c	2006-06-19 05:17:36.000000000 -0400
+++ /export/public/clemep/tmp/super1-ppc-compile-error.c	2006-06-19 00:40:26.000000000 -0400
@@ -124,8 +124,11 @@ static unsigned int calc_sb_1_csum(struc
 	disk_csum = sb->sb_csum;
 	sb->sb_csum = 0;
 	newcsum = 0;
-	for (i=0; size>=4; size -= 4 )
-		newcsum += __le32_to_cpu(*isuper++);
+	for (i=0; size>=4; size -= 4 ) {
+		unsigned int *x = isuper;
+		newcsum += __le32_to_cpu(*x);
+		x++;
+	}
 
 	if (size == 2)
 		newcsum += __le16_to_cpu(*(unsigned short*) isuper);

Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Paul Clements]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

> Neil Brown wrote:
> I am pleased to announce the availability of
>    mdadm version 2.5.1

What the heck, here's another one. :) This one is slightly more serious. 
We're getting a device of "0:0" in "Fail" events from the mdadm monitor 
sometimes now (due to the change in map_dev, which allows it to 
sometimes return "0:0" instead of just NULL for an unknown device).

The patch fixes my issue. I don't know if there are more.

Thanks,
Paul

[-- Attachment #2: mdadm-2.5.1-dev0:0-monitor-fix.diff --]
[-- Type: text/plain, Size: 430 bytes --]

--- mdadm-2.5.1/Monitor.c	Thu Jun  1 21:33:41 2006
+++ mdadm-2.5.1-new/Monitor.c	Mon Jun 19 14:51:31 2006
@@ -328,7 +328,7 @@ int Monitor(mddev_dev_t devlist,
 					}
 					disc.major = disc.minor = 0;
 				}
-				if (dv == NULL && st->devid[i])
+				if ((dv == NULL || strcmp(dv, "0:0") == 0) && st->devid[i])
 					dv = map_dev(major(st->devid[i]),
 						     minor(st->devid[i]), 1);
 				change = newstate ^ st->devstate[i];

Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Paul Clements]

Paul Clements wrote:

> --- super1.c	2006-06-19 05:17:36.000000000 -0400
> +++ /export/public/clemep/tmp/super1-ppc-compile-error.c	2006-06-19 00:40:26.000000000 -0400
> @@ -124,8 +124,11 @@ static unsigned int calc_sb_1_csum(struc
>  	disk_csum = sb->sb_csum;
>  	sb->sb_csum = 0;
>  	newcsum = 0;
> -	for (i=0; size>=4; size -= 4 )
> -		newcsum += __le32_to_cpu(*isuper++);
> +	for (i=0; size>=4; size -= 4 ) {
> +		unsigned int *x = isuper;
> +		newcsum += __le32_to_cpu(*x);
> +		x++;
> +	}

Should be more like:

for (i=0; size>=4; size -= 4 ) {
	newcsum += __le32_to_cpu(*isuper);
	isuper++;
}

Duh... :)

Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Neil Brown]

On Monday June 19, paul.clements@steeleye.com wrote:
> > Neil Brown wrote:
> > I am pleased to announce the availability of
> >    mdadm version 2.5.1
> 
> What the heck, here's another one. :) This one is slightly more serious. 
> We're getting a device of "0:0" in "Fail" events from the mdadm monitor 
> sometimes now (due to the change in map_dev, which allows it to 
> sometimes return "0:0" instead of just NULL for an unknown device).
> 

Thanks for this and the other two.  They are now in .git

> The patch fixes my issue. I don't know if there are more.
> 

I chose to do this differently - map_dev will now return NULL for 0,0
and all users can cope with a NULL.

NeilBrown



> Thanks,
> Paul
> --- mdadm-2.5.1/Monitor.c	Thu Jun  1 21:33:41 2006
> +++ mdadm-2.5.1-new/Monitor.c	Mon Jun 19 14:51:31 2006
> @@ -328,7 +328,7 @@ int Monitor(mddev_dev_t devlist,
>  					}
>  					disc.major = disc.minor = 0;
>  				}
> -				if (dv == NULL && st->devid[i])
> +				if ((dv == NULL || strcmp(dv, "0:0") == 0) && st->devid[i])
>  					dv = map_dev(major(st->devid[i]),
>  						     minor(st->devid[i]), 1);
>  				change = newstate ^ st->devstate[i];