Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Paul Clements <paul.clements@steeleye.com>]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

> Neil Brown wrote:
> I am pleased to announce the availability of
>    mdadm version 2.5.1

What the heck, here's another one. :) This one is slightly more serious. 
We're getting a device of "0:0" in "Fail" events from the mdadm monitor 
sometimes now (due to the change in map_dev, which allows it to 
sometimes return "0:0" instead of just NULL for an unknown device).

The patch fixes my issue. I don't know if there are more.

Thanks,
Paul

[-- Attachment #2: mdadm-2.5.1-dev0:0-monitor-fix.diff --]
[-- Type: text/plain, Size: 430 bytes --]

--- mdadm-2.5.1/Monitor.c	Thu Jun  1 21:33:41 2006
+++ mdadm-2.5.1-new/Monitor.c	Mon Jun 19 14:51:31 2006
@@ -328,7 +328,7 @@ int Monitor(mddev_dev_t devlist,
 					}
 					disc.major = disc.minor = 0;
 				}
-				if (dv == NULL && st->devid[i])
+				if ((dv == NULL || strcmp(dv, "0:0") == 0) && st->devid[i])
 					dv = map_dev(major(st->devid[i]),
 						     minor(st->devid[i]), 1);
 				change = newstate ^ st->devstate[i];