From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Davidsen Subject: Re: [PATCH] md: Fix for raid6 reshape. Date: Fri, 02 Mar 2007 15:34:24 -0500 Message-ID: <45E88A50.8060906@tmr.com> References: <20070302155626.19014.patches@notabene> <1070302045655.19069@suse.de> <20070301223619.d9957521.akpm@linux-foundation.org> <17895.50900.585915.565155@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <17895.50900.585915.565155@notabene.brown> Sender: linux-raid-owner@vger.kernel.org To: Neil Brown Cc: Andrew Morton , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids Neil Brown wrote: > On Thursday March 1, akpm@linux-foundation.org wrote: > >> On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown wrote: >> >> >>> - conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1); >>> + conf->expand_progress = (sector_nr + i) * new_data_disks); >>> >> ahem. >> > > > It wasn't like that when I tested it, honest... > But the original got caught up with some other changes which were not > really related so I removed them all and just made this change > manually.... and totally messed it up (again). Sorry. > > Of course it should be > > >>> + conf->expand_progress = (sector_nr + i) * new_data_disks; >>> Will the (real) fix be in 2.6.21? -- bill davidsen CTO TMR Associates, Inc Doing interesting things with small computers since 1979