linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	mingo@redhat.com, neilb@suse.de, linux-raid@vger.kernel.org
Subject: Re: raid6 rebuild
Date: Thu, 05 Apr 2007 09:54:14 -0400	[thread overview]
Message-ID: <4614FF86.3020007@tmr.com> (raw)
In-Reply-To: <20070405055030.GA6978@xi.wantstofly.org>

Lennert Buytenhek wrote:
> On Wed, Apr 04, 2007 at 08:22:00PM -0700, Dan Williams wrote:
>
>   
>>> While my RAID6 array was rebuilding after one disk had failed (which
>>> I replaced), a second disk failed[*], and this caused the rebuild
>>> process to start over from the beginning.
>>>
>>> Why would the rebuild need to start over from the beginning in this
>>> case?  Why couldn't it just continue from where it was?
>>>       
>> I believe it is because raid5 and raid6 share the same error handler
>> which sets MD_RECOVERY_ERR after losing any disk.  It should probably
>> not set this flag in 1-disk lost raid6 case, but I might be
>> overlooking something else.
>>     
>
> Right, so you're saying that it's probably a bug rather than an
> intentional 'feature'?

No, I would say it's a "reviewable design decision" To be pedantic (as I 
often am), a bug really means that unintended results are generated. In 
this case I think the code functions as intended, but might be able to 
safely take some other action.

I confess, I would feel safer with my data if the rebuild started over, 
I would like to be sure that when it (finally) finishes the data are 
valid. If you replaced the 2nd drive, then a full rebuild would be 
required in any case, to get ALL drives valid.

-- 
bill davidsen <davidsen@tmr.com>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979


  reply	other threads:[~2007-04-05 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04 19:46 raid6 rebuild Lennert Buytenhek
2007-04-05  3:22 ` Dan Williams
2007-04-05  5:50   ` Lennert Buytenhek
2007-04-05 13:54     ` Bill Davidsen [this message]
2007-04-05 14:06       ` Lennert Buytenhek
2007-04-05 16:59         ` Dan Williams
2007-04-11  1:43           ` Neil Brown
2007-04-05  6:03 ` Gordon Henderson
2007-04-05  6:21   ` Lennert Buytenhek
2007-04-05  8:15     ` Gordon Henderson
2007-04-05  8:48       ` Lennert Buytenhek
2007-04-05 10:13 ` Andre Noll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4614FF86.3020007@tmr.com \
    --to=davidsen@tmr.com \
    --cc=buytenh@wantstofly.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).