linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colin McCabe <Colin.P.McCabe@gmail.com>
Cc: linux-raid@vger.kernel.org, linux-hotplug-devel@lists.sourceforge.net
Subject: Re: removed disk && md-device
Date: Wed, 16 May 2007 17:19:44 -0400	[thread overview]
Message-ID: <464B7570.2070809@gmail.com> (raw)
In-Reply-To: <17986.50678.340484.891578@notabene.brown>

Neil Brown wrote:
> On Wednesday May 9, bs@q-leap.de wrote:
>> Neil Brown <neilb@suse.de> [2007.04.02.0953 +0200]:
>>> Hmmm... this is somewhat awkward.  You could argue that udev should be
>>> taught to remove the device from the array before removing the device
>> >from /dev.  But I'm not convinced that you always want to 'fail' the
>>> device.   It is possible in this case that the array is quiescent and
>>> you might like to shut it down without registering a device failure...
>> Hmm, the the kernel advised hotplug to remove the device from /dev, but you 
>> don't want to remove it from md? Do you have an example for that case?
> 
> Until there is known to be an inconsistency among the devices in an
> array, you don't want to record that there is.

Keeping admins in the dark about hotplug is a misfeature.

If you look at /proc/mdstat and you see 4 devices, but actually the 
janitor unplugged them all yesterday, you are just going to be more 
confused when things eventually fail, not less. It's a like a fuel gauge 
that says "full," but actually there's only a few drops left in the tank.

> Suppose I have two USB drives with a mounted but quiescent filesystem
> on a raid1 across them.
> I pull them both out, one after the other, to take them to my friends
> place.
> 
> I plug them both in and find that the array is degraded, because as
> soon as I unplugged on, the other was told that it was now the only
> one. 

Filesystems have mount / umount; RAID has mdadm --assemble / mdadm 
--stop. If you start pulling disks without doing the necessary cleanup, 
you should EXPECT the array to go into a degraded state.

Colin


> Not good.  Best to wait for an IO request that actually returns an
> errors. 
> 
>>> Maybe an mdadm command that will do that for a given device, or for
>>> all components of a given array if the 'dev' link is 'broken', or even
>>> for all devices for all array.
>>>   mdadm --fail-unplugged --scan
>>> or
>>>   mdadm --fail-unplugged /dev/md3
>> Ok, so one could run this as cron script. Neil, may I ask if you already 
>> started to work on this? Since we have the problem on a customer system, we 
>> should fix it ASAP, but at least within the next 2 or 3 weeks. If you didn't 
>> start work on it yet, I will do...
> 
> No, I haven't, but it is getting near the top of my list.
> If you want a script that does this automatically for every array,
> something like:
> 
>   for a in /sys/block/md*/md/dev-*
>   do
>     if [ -f $a/block/dev ]
>     then : still there
>     else
> 	echo faulty > $a/state
> 	echo remove > $a/state
>     fi
>   done
> 
> should do what you want. (I haven't tested it though).
> 
> NeilBrown
> -
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-05-16 21:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-09 12:17 removed disk && md-device Bernd Schubert
2007-05-09 13:14 ` martin f krafft
2007-05-09 13:39   ` Bernd Schubert
2007-05-10  7:12     ` Neil Brown
2007-05-10 14:33       ` David Greaves
2007-05-11  1:36         ` Neil Brown
2007-05-11  8:51           ` Michael Tokarev
2007-05-11  9:22             ` Bernd Schubert
2007-05-11 20:39               ` Bill Davidsen
2007-05-15  9:52                 ` Goswin von Brederlow
2007-05-11  8:52           ` David Greaves
2007-05-11 15:05           ` David Greaves
2007-05-11 20:50           ` David Greaves
2007-05-10 18:17       ` Bernd Schubert
2007-05-11  6:16       ` Neil Brown
2007-05-11 20:47         ` Bill Davidsen
2007-05-16 21:19       ` Colin McCabe [this message]
2007-05-09 21:41 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464B7570.2070809@gmail.com \
    --to=colin.p.mccabe@gmail.com \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).