* [PATCH] Detail: show correct bitmap info for cluster raid device
@ 2020-03-13 9:05 Lidong Zhong
2020-03-13 15:07 ` Guoqing Jiang
0 siblings, 1 reply; 4+ messages in thread
From: Lidong Zhong @ 2020-03-13 9:05 UTC (permalink / raw)
To: jes; +Cc: linux-raid, guoqing.jiang
Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>
---
Detail.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Detail.c b/Detail.c
index 832485f..39fce29 100644
--- a/Detail.c
+++ b/Detail.c
@@ -468,7 +468,9 @@ int Detail(char *dev, struct context *c)
if (ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 && bmf.pathname[0]) {
printf(" Intent Bitmap : %s\n", bmf.pathname);
printf("\n");
- } else if (array.state & (1<<MD_SB_BITMAP_PRESENT))
+ } else if (array.state & (1<<MD_SB_CLUSTERED))
+ printf(" Intent Bitmap : Clustered\n\n");
+ else if (array.state & (1<<MD_SB_BITMAP_PRESENT))
printf(" Intent Bitmap : Internal\n\n");
atime = array.utime;
if (atime)
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Detail: show correct bitmap info for cluster raid device
2020-03-13 9:05 Lidong Zhong
@ 2020-03-13 15:07 ` Guoqing Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Guoqing Jiang @ 2020-03-13 15:07 UTC (permalink / raw)
To: Lidong Zhong, jes; +Cc: linux-raid
Hi Lidong,
On 3/13/20 10:05 AM, Lidong Zhong wrote:
> Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>
> ---
> Detail.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Detail.c b/Detail.c
> index 832485f..39fce29 100644
> --- a/Detail.c
> +++ b/Detail.c
> @@ -468,7 +468,9 @@ int Detail(char *dev, struct context *c)
> if (ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 && bmf.pathname[0]) {
> printf(" Intent Bitmap : %s\n", bmf.pathname);
> printf("\n");
> - } else if (array.state & (1<<MD_SB_BITMAP_PRESENT))
> + } else if (array.state & (1<<MD_SB_CLUSTERED))
> + printf(" Intent Bitmap : Clustered\n\n");
Better to use "Internal (Clustered)" since it is a special internal bitmap.
Anyway, Acked-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Cheers,
Guoqing
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Detail: show correct bitmap info for cluster raid device
@ 2020-03-16 2:16 Lidong Zhong
2020-03-16 21:50 ` Jes Sorensen
0 siblings, 1 reply; 4+ messages in thread
From: Lidong Zhong @ 2020-03-16 2:16 UTC (permalink / raw)
To: jes; +Cc: linux-raid, guoqing.jiang
Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>
---
Detail.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Detail.c b/Detail.c
index 832485f..daec4f1 100644
--- a/Detail.c
+++ b/Detail.c
@@ -468,7 +468,9 @@ int Detail(char *dev, struct context *c)
if (ioctl(fd, GET_BITMAP_FILE, &bmf) == 0 && bmf.pathname[0]) {
printf(" Intent Bitmap : %s\n", bmf.pathname);
printf("\n");
- } else if (array.state & (1<<MD_SB_BITMAP_PRESENT))
+ } else if (array.state & (1<<MD_SB_CLUSTERED))
+ printf(" Intent Bitmap : Internal(Clustered)\n\n");
+ else if (array.state & (1<<MD_SB_BITMAP_PRESENT))
printf(" Intent Bitmap : Internal\n\n");
atime = array.utime;
if (atime)
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Detail: show correct bitmap info for cluster raid device
2020-03-16 2:16 [PATCH] Detail: show correct bitmap info for cluster raid device Lidong Zhong
@ 2020-03-16 21:50 ` Jes Sorensen
0 siblings, 0 replies; 4+ messages in thread
From: Jes Sorensen @ 2020-03-16 21:50 UTC (permalink / raw)
To: Lidong Zhong; +Cc: linux-raid, guoqing.jiang
On 3/15/20 10:16 PM, Lidong Zhong wrote:
> Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>
> ---
> Detail.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-16 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-16 2:16 [PATCH] Detail: show correct bitmap info for cluster raid device Lidong Zhong
2020-03-16 21:50 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2020-03-13 9:05 Lidong Zhong
2020-03-13 15:07 ` Guoqing Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).