linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: maximilian attems <max@stro.at>
Cc: linux-raid@vger.kernel.org, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] [mdadm] Add klibc support to mdadm.h
Date: Tue, 02 Oct 2007 18:50:07 -0700	[thread overview]
Message-ID: <4702F54F.1070504@zytor.com> (raw)
In-Reply-To: <11903959391007-git-send-email-max@stro.at>

maximilian attems wrote:
> klibc still misses a lot functionality to let mdadm link against,
> this small step helps to get to the real trouble.. :)
> 
> Signed-off-by: maximilian attems <max@stro.at>
> ---
>  mdadm.h |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/mdadm.h b/mdadm.h
> index ac7d4b4..dba09f0 100644
> --- a/mdadm.h
> +++ b/mdadm.h
> @@ -29,7 +29,7 @@
>  
>  #define	_GNU_SOURCE
>  #include	<unistd.h>
> -#ifndef __dietlibc__
> +#if !defined(__dietlibc__) && !defined(__KLIBC__)
>  extern __off64_t lseek64 __P ((int __fd, __off64_t __offset, int __whence));
>  #else

Wouldn't it be better to just compile with -D_FILE_OFFSET_BITS=64 on all 
libraries instead of using the LFS cruft?

	-hpa

      parent reply	other threads:[~2007-10-03  1:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 17:32 [PATCH] [mdadm] Add klibc support to mdadm.h maximilian attems
2007-09-21 17:32 ` [PATCH] [mdadm] config.c include dirent.h instead sys/dir.h maximilian attems
2007-09-21 17:32   ` [PATCH] [mdadm] Create.c s/major/major_num/ maximilian attems
2007-09-24  3:22 ` [PATCH] [mdadm] Add klibc support to mdadm.h Neil Brown
2007-10-03  1:50 ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4702F54F.1070504@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=max@stro.at \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).