Re: [md-raid6-accel PATCH 02/12] async_tx: RAID-6 recovery implementation

["H. Peter Anvin" <hpa@zytor.com>]

Yuri Tikhonov wrote:
>  This patch adds support for asynchronous RAID-6 recovery operations.
> 
>  An asynchronous implementation using async_tx API is provided to compute
> two missing data blocks (async_r6_dd_recov) and to compute one missing data
> block and one missing parity_block (async_r6_dp_recov).
> 
>  In general, the RAID-6 recovery API is the wrappers which organize the
> calculations algorithms using async_pqxor().
> 
>  Please refer to the "The mathematics of RAID-6" wtite-paper written by
> H.Peter Anvin available at www.kernel.org/pub/linux/kernel/people/hpa/raid6.pdf
> for the theoretical basement of the algorithms implemented here.
> 
>  Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>  Signed-off-by: Mikhail Cherkashin <mike@emcraft.com>
> --

I really, *really*, don't like the name "pqxor", because it is actively 
misleading.  The P syndrome is an XOR, but the Q syndrome is not, and in 
particular, does not exhibit the same properties as one would expect 
from an XOR, in particular commutativity.

	-hpa