* do_md_run returned -22 [Was: 2.6.24-rc8-mm1] [not found] <20080117023514.9df393cf.akpm@linux-foundation.org> @ 2008-01-17 15:23 ` Jiri Slaby 2008-01-17 19:01 ` Andrew Morton 0 siblings, 1 reply; 3+ messages in thread From: Jiri Slaby @ 2008-01-17 15:23 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, Torsten Kaiser, NeilBrown, mingo, linux-raid On 01/17/2008 11:35 AM, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ still the same md issue (do_md_run returns -22=EINVAL) as in -rc6-mm1 reported by Thorsten here: http://lkml.org/lkml/2007/12/27/45 Is there around any fix for this? Having 0.90 raid 0 and 1, commenting this out helps: diff --git a/drivers/md/md.c b/drivers/md/md.c index 8633bd4..9b8ecc8 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3292,8 +3292,8 @@ static int do_md_run(mddev_t * mddev) * Analyze all RAID superblock(s) */ if (!mddev->raid_disks) { - if (!mddev->persistent) - return -EINVAL; +/* if (!mddev->persistent) + return -EINVAL;*/ analyze_sbs(mddev); } The persistency is marked even in analyze_sbs->validate_super, I guess? ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: do_md_run returned -22 [Was: 2.6.24-rc8-mm1] 2008-01-17 15:23 ` do_md_run returned -22 [Was: 2.6.24-rc8-mm1] Jiri Slaby @ 2008-01-17 19:01 ` Andrew Morton 2008-01-17 23:15 ` Neil Brown 0 siblings, 1 reply; 3+ messages in thread From: Andrew Morton @ 2008-01-17 19:01 UTC (permalink / raw) To: Jiri Slaby; +Cc: linux-kernel, Torsten Kaiser, NeilBrown, mingo, linux-raid On Thu, 17 Jan 2008 16:23:30 +0100 Jiri Slaby <jirislaby@gmail.com> wrote: > On 01/17/2008 11:35 AM, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > > still the same md issue (do_md_run returns -22=EINVAL) as in -rc6-mm1 reported > by Thorsten here: > http://lkml.org/lkml/2007/12/27/45 hm, I must have been asleep when that was reported. Neil, did you see it? > Is there around any fix for this? Well, we could bitbucket md-allow-devices-to-be-shared-between-md-arrays.patch > Having 0.90 raid 0 and 1, commenting this out helps: > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 8633bd4..9b8ecc8 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -3292,8 +3292,8 @@ static int do_md_run(mddev_t * mddev) > * Analyze all RAID superblock(s) > */ > if (!mddev->raid_disks) { > - if (!mddev->persistent) > - return -EINVAL; > +/* if (!mddev->persistent) > + return -EINVAL;*/ > analyze_sbs(mddev); > } > > The persistency is marked even in analyze_sbs->validate_super, I guess? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: do_md_run returned -22 [Was: 2.6.24-rc8-mm1] 2008-01-17 19:01 ` Andrew Morton @ 2008-01-17 23:15 ` Neil Brown 0 siblings, 0 replies; 3+ messages in thread From: Neil Brown @ 2008-01-17 23:15 UTC (permalink / raw) To: Andrew Morton; +Cc: Jiri Slaby, linux-kernel, Torsten Kaiser, mingo, linux-raid On Thursday January 17, akpm@linux-foundation.org wrote: > On Thu, 17 Jan 2008 16:23:30 +0100 Jiri Slaby <jirislaby@gmail.com> wrote: > > > On 01/17/2008 11:35 AM, Andrew Morton wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > > > > still the same md issue (do_md_run returns -22=EINVAL) as in -rc6-mm1 reported > > by Thorsten here: > > http://lkml.org/lkml/2007/12/27/45 > > hm, I must have been asleep when that was reported. Neil, did you see it? No, even though it was Cc:ed to me - sorry. Maybe a revised subject line would have helped... maybe not. > > > Is there around any fix for this? > > Well, we could bitbucket md-allow-devices-to-be-shared-between-md-arrays.patch Yeah, do that. I'll send you something new. I'll move that chunk into a different patch and add the extra bits needed to make that test correct in *all* cases rather than just the ones I was thinking about at the time. My test suit does try in-kernel-autodetect (the problem case) but it didn't catch this bug due to another bug. I'll fix that too. Thanks, NeilBrown ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-17 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080117023514.9df393cf.akpm@linux-foundation.org>
2008-01-17 15:23 ` do_md_run returned -22 [Was: 2.6.24-rc8-mm1] Jiri Slaby
2008-01-17 19:01 ` Andrew Morton
2008-01-17 23:15 ` Neil Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).