From: David Greaves <david@dgreaves.com>
To: Greg KH <greg@kroah.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
LinuxRaid <linux-raid@vger.kernel.org>
Subject: RFI for 2.6.25.5 : Re: Regression- XFS won't mount on partitioned md array
Date: Sat, 24 May 2008 14:33:35 +0100 [thread overview]
Message-ID: <4838192F.3050004@dgreaves.com> (raw)
In-Reply-To: <482FED60.7060405@dgreaves.com>
Hi Greg
Perusing:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git
doesn't show the patch referenced below as in the queue for 2.6.25.5
David
David Greaves wrote:
> Eric Sandeen wrote:
>> Eric Sandeen wrote:
>>> Eric Sandeen wrote:
>>>
>>>> I'll see if I have a little time today to track down the problem.
>>> Does this patch fix it for you? Does for me though I can't yet explain
>>> why ;)
>>>
>>> http://www.linux.sgi.com/archives/xfs/2008-05/msg00190.html
>>>
>>> -Eric
> Yes, this fixes it for me - thanks :)
>
>> So what's happening is that xfs is trying to read a page-sized IO from
>> the last sector of the log... which goes off the end of the device.
>> This looks like another regression introduced by
>> a9759f2de38a3443d5107bddde03b4f3f550060e, but fixed by Christoph's patch
>> in the URL above, which should be headed towards -stable.
> Damn, I guess I misread my bisect readings when things crashed then.
> Still, I said 'around' :)
>
>> (aside: it seems that this breaks any external log setup where the log
>> consists of the entire device... but I'd have expected the xfsqa suite
>> to catch this...?)
>>
>> The patch avoids the problem by looking for some extra locking but it
>> seems to me that the root cause is that the buffer being read at this
>> point doesn't have it's b_offset, the offset in it's page, set. Might
>> be another little buglet but harmless it seems.
next prev parent reply other threads:[~2008-05-24 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 17:11 Regression- XFS won't mount on partitioned md array David Greaves
2008-05-16 17:16 ` Justin Piszcz
2008-05-16 18:05 ` David Greaves
2008-05-16 18:35 ` Oliver Pinter
2008-05-17 14:48 ` David Greaves
2008-05-17 15:20 ` David Greaves
2008-05-16 18:59 ` Eric Sandeen
2008-05-17 14:46 ` David Greaves
2008-05-17 15:15 ` Eric Sandeen
2008-05-17 19:10 ` Mechanism to safely force repair of single md stripe w/o hurting data integrity of file system David Lethe
2008-05-17 19:29 ` Peter Rabbitson
2008-05-17 20:26 ` Guy Watkins
2008-05-26 11:17 ` Jan Engelhardt
2008-05-19 2:54 ` Neil Brown
2008-05-17 23:18 ` Regression- XFS won't mount on partitioned md array Eric Sandeen
[not found] ` <482FBD4C.20608@sandeen.net>
2008-05-18 8:48 ` David Greaves
2008-05-18 15:38 ` Eric Sandeen
2008-05-24 13:33 ` David Greaves [this message]
2008-05-24 13:52 ` RFI for 2.6.25.5 : " Willy Tarreau
2008-05-24 15:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4838192F.3050004@dgreaves.com \
--to=david@dgreaves.com \
--cc=dgc@sgi.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).