From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Subject: Re: [PATCH v3 2/3] bcache: update document info Date: Mon, 4 Jul 2016 13:49:57 +0800 Message-ID: <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li> References: <1467595414-20844-1-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1467595414-20844-1-git-send-email-wangyijing@huawei.com> Sender: linux-bcache-owner@vger.kernel.org To: Yijing Wang , axboe@fb.com, Kent Overstreet Cc: Eric Wheeler , Coly Li , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids =D4=DA 16/7/4 =C9=CF=CE=E79:23, Yijing Wang =D0=B4=B5=C0: > There is no return in continue_at(), update the documentation. >=20 Thanks. Acked-by: Coly Li > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/closure.c | 2 +- > drivers/md/bcache/closure.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.= c > index 9eaf1d6..864e673 100644 > --- a/drivers/md/bcache/closure.c > +++ b/drivers/md/bcache/closure.c > @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitli= st, struct closure *cl) > EXPORT_SYMBOL(closure_wait); > =20 > /** > - * closure_sync - sleep until a closure a closure has nothing left t= o wait on > + * closure_sync - sleep until a closure has nothing left to wait on > * > * Sleeps until the refcount hits 1 - the thread that's running the = closure owns > * the last refcount. > diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.= h > index 782cc2c..9b2fe2d 100644 > --- a/drivers/md/bcache/closure.h > +++ b/drivers/md/bcache/closure.h > @@ -31,7 +31,8 @@ > * passing it, as you might expect, the function to run when nothing= is pending > * and the workqueue to run that function out of. > * > - * continue_at() also, critically, is a macro that returns the calli= ng function. > + * continue_at() also, critically, requires a 'return' immediately f= ollowing the > + * location where this macro is referenced, to return to the calling= function. > * There's good reason for this. > * > * To use safely closures asynchronously, they must always have a re= fcount while >=20 --=20 Coly Li