From: Jes Sorensen <jes.sorensen@gmail.com>
To: Song Liu <songliubraving@fb.com>, linux-raid@vger.kernel.org
Cc: shli@fb.com, neilb@suse.com, kernel-team@fb.com,
dan.j.williams@intel.com, hch@infradead.org
Subject: Re: [PATCH v2] mdadm: set journal_clean after scanning all disks
Date: Fri, 1 Sep 2017 11:12:55 -0400 [thread overview]
Message-ID: <48c74e1d-4cfc-5624-1065-36d2f44f0dac@gmail.com> (raw)
In-Reply-To: <20170829165302.3526230-1-songliubraving@fb.com>
On 08/29/2017 12:53 PM, Song Liu wrote:
> Summary:
> In Incremental.c:count_active(), max_events is tracked to show to
> which devices are up to date. If a device has events==max_events+1,
> getinfo_super() is called to reload the superblock from this
> device. getinfo_super1() blindly set journal_clean to 0, which is
> wrong.
>
> This patch fixes this by tracking max_journal_events for all the
> disks. After scanning all disks, journal_clean is set if
> max_journal_events >= max_events-1.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Applied!
Thanks,
Jes
prev parent reply other threads:[~2017-09-01 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 16:53 [PATCH v2] mdadm: set journal_clean after scanning all disks Song Liu
2017-08-29 20:45 ` NeilBrown
2017-09-01 15:12 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c74e1d-4cfc-5624-1065-36d2f44f0dac@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).