linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [mdadm git pull] "--assemble --scan" support for imsm
Date: Wed, 05 Nov 2008 08:40:13 -0700	[thread overview]
Message-ID: <4911BE5D.2060605@intel.com> (raw)
In-Reply-To: <18704.10588.526784.38341@notabene.brown>

Neil Brown wrote:
> I haven't included your
> 
>    Let symlinks to standard devices count as standard names
> 
> patch because I don't think I agree with it, and I don't think it is
> needed any more.
> 

My concern was that:
for i in `seq 1 5`
do
	mdadm -As
	mdadm -Ss
done

...would create 5 different device numbers.  Your right it is better 
now, but between successive assemblies the device numbers still toggle 
between two different values.  So it's just a small cosmetic issue now. 
  Are their lifetime issues that preclude predictable device numbers?

> I also have left out your
> 
>      imsm: match_home(), document why it is stubbed out
>     
> because I don't understand.  Maybe some more words about how
> 'family_num' can distinguish between "Local" and "Foreign". ??
> 

...it doesn't.  'family_num' is a checksum that includes the serial 
numbers of the component disks when the array was first created.  So it 
can help determine when two arrays were created in different places, but 
the metadata can't identify which, if any, is "Local".

I'll redo the comment.

Thanks for the pull and the review,
Dan

  reply	other threads:[~2008-11-05 15:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 21:44 [mdadm git pull] "--assemble --scan" support for imsm Dan Williams
2008-10-29  9:19 ` Neil Brown
2008-10-29 16:12   ` Dan Williams
2008-10-30  3:42     ` Neil Brown
2008-11-02 23:15       ` Dan Williams
2008-11-04 10:52         ` Neil Brown
2008-11-05 15:40           ` Dan Williams [this message]
2008-10-30 12:43   ` Neil Brown
     [not found] <4C69D525.4060404@gmail.com>
2010-08-17 16:49 ` Dan Williams
2010-08-17 18:48   ` Jiang, Dave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4911BE5D.2060605@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).