linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jon Nelson <jnelson-linux-raid@jamponi.net>
Cc: Neil Brown <neilb@suse.de>, LinuxRaid <linux-raid@vger.kernel.org>
Subject: Re: raid1 recovery: reads and writes
Date: Tue, 16 Dec 2008 14:04:58 -0700	[thread overview]
Message-ID: <494817FA.5040108@intel.com> (raw)
In-Reply-To: <cccedfc60812151840g8febe5ayfda29ae609bca9df@mail.gmail.com>

Jon Nelson wrote:
> ..
> 
>> Yes it is hard to guess what is happening here; however, should not
>> the following commit go to -stable?
>>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=56ac36d722d0d27c03599d1245ac0ab59e474e5c
> 
> Is it possible this commit is (partially) responsible for what I was
> seeing? Under what conditions would it trigger?

I don't think this commit is responsible, it's a fix for a case where 
the kernel was asked to do a repair but a recovery is pending.

This commit addressed a bug in external-metadata support when adding a 
spare disk via sysfs.  It would be fairly difficult to trigger this in 
the non-external-metadata case.   It would require a check/repair 
request to come in immediately after the disk was (re-)added, but before 
the kernel started the resync.

--
Dan

      reply	other threads:[~2008-12-16 21:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 13:45 raid1 recovery: reads and writes Jon Nelson
2008-12-15 21:09 ` Neil Brown
2008-12-16  0:54   ` Dan Williams
2008-12-16  2:40     ` Jon Nelson
2008-12-16 21:04       ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494817FA.5040108@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=jnelson-linux-raid@jamponi.net \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).