linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Robinson <john.robinson@anonymous.org.uk>
To: NeilBrown <neilb@suse.de>
Cc: Doug Ledford <dledford@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-raid <linux-raid@vger.kernel.org>
Subject: When read-only isn't read-only (was Re: [mdadm git pull] imsm fixes and general external metadata updates)
Date: Tue, 24 Feb 2009 23:33:16 +0000	[thread overview]
Message-ID: <49A483BC.4090603@anonymous.org.uk> (raw)
In-Reply-To: <78a6226da1dee8c5b070b9ee30ee4705.squirrel@neil.brown.name>

On 23/02/2009 20:16, NeilBrown wrote:
> On Tue, February 24, 2009 6:53 am, Doug Ledford wrote:
>> Is XFS the only one that does the journal recovery on initial mount
>> read-only during the initfs step, or do other journaled fses do the same
>> thing?  I didn't think ext3 recovered the journal until you switch to a
>> read-write mount, but I guess I could be wrong.
> 
> This from fs/ext3/super.c
> 
> 	if (EXT3_HAS_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER)) {
> 		if (sb->s_flags & MS_RDONLY) {
> 			printk(KERN_INFO "EXT3-fs: INFO: recovery "
> 					"required on readonly filesystem.\n");
> 			if (really_read_only) {
> 				printk(KERN_ERR "EXT3-fs: write access "
> 					"unavailable, cannot proceed.\n");
> 				return -EROFS;
> 			}
> 			printk (KERN_INFO "EXT3-fs: write access will "
> 					"be enabled during recovery.\n");
> 		}
> 	}
> 
> suggests that, unfortunately, you are.

Presumably it's not only me that thinks this is insane? If I want to 
mount a filesystem read-only, I expect it to be mounted read-only; 
perhaps I already know it's damaged, or know the journal's damaged...

I guess I can see the journal recovery normally being the right thing, 
and it is the filesystem we asked to have read-only not the disc, but 
still there surely has to be a way of saying mount without journal 
recovery, or mount without writing to disc, or both, and if there isn't 
who do I ask to implement it? (I'm way too rusty as a coder to trust 
myself to get it even half right.)

I wonder: in the case of ext3 can I mount it as ext2 and thereby have 
the journal ignored rather than recovered? And would this be sufficient 
for the initrd context?

Cheers,

John.


  parent reply	other threads:[~2009-02-24 23:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 22:20 [mdadm git pull] imsm fixes and general external metadata updates Dan Williams
2009-01-23 22:51 ` Dan Williams
2009-02-01 23:46 ` Neil Brown
2009-02-23 15:54   ` Doug Ledford
2009-02-23 18:58     ` Dan Williams
2009-02-23 19:53       ` Doug Ledford
2009-02-23 20:16         ` NeilBrown
2009-02-24  7:57           ` Luca Berra
2009-02-24 23:33           ` John Robinson [this message]
2009-02-24 23:45             ` When read-only isn't read-only (was Re: [mdadm git pull] imsm fixes and general external metadata updates) Greg Freemyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A483BC.4090603@anonymous.org.uk \
    --to=john.robinson@anonymous.org.uk \
    --cc=dan.j.williams@intel.com \
    --cc=dledford@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).