Re: [PATCH/Resend] md: Push down data integrity code to personalities.

[Bill Davidsen <davidsen@tmr.com>]

Neil Brown wrote:
> On Wednesday July 1, maan@systemlinux.org wrote:
>   
>> Hi Neil,
>>
>> here's again the patch that reduces the knowledge about specific
>> raid levels from md.c by moving the data integrity code to the
>> personalities. The patch was tested and acked by Martin.
>>
>> Please review.
>>     
>
> Apologies for the delay.  I've been fighting a flu :-(
>
> This patch seems to treat spares inconsistently.
>
> md_integrity_register ignores spares.
> However bind_rdev_to_array - which is used for adding a spare - calls
> md_integrity_add_rdev to check that the integrity profile of the new
> device matches.
>
> We need to be consistent.
> Either all devices that are bound to the array - whether active,
> spare, or failed - are considered, or only the active devices are
> considered.
>
> In the former case we want to take action in bind_rdev_to_array
> and possibly in unbind_rdev_from_array.
> In the latter we need to take action either in remove_and_add_spares,
> or in the per-personality ->hot_add_disk and ->hot_remove_disk
> methods.
>
> I think I lean towards the latter, and put code in ->hot_*_disk, but
> it isn't a strong leaning.
>   

Does this open problems with shared spares between arrays of different 
types?

-- 
Bill Davidsen <davidsen@tmr.com>
  Obscure bug of 2004: BASH BUFFER OVERFLOW - if bash is being run by a
normal user and is setuid root, with the "vi" line edit mode selected,
and the character set is "big5," an off-by-one error occurs during
wildcard (glob) expansion.