From: "H. Peter Anvin" <hpa@zytor.com>
To: Mike Snitzer <snitzer@gmail.com>
Cc: NeilBrown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: Re: [md PATCH 8/8] md: Use revalidate_disk to effect changes in size of device.
Date: Wed, 05 Aug 2009 18:15:18 -0700 [thread overview]
Message-ID: <4A7A2EA6.9020603@zytor.com> (raw)
In-Reply-To: <170fa0d20908051803ud6ef819xdad3cafe44cc1fb8@mail.gmail.com>
On 08/05/2009 06:03 PM, Mike Snitzer wrote:
> On Wed, Aug 5, 2009 at 6:07 PM, H. Peter Anvin<hpa@zytor.com> wrote:
>> On 08/02/2009 02:58 PM, NeilBrown wrote:
>>> As revalidate_disk calls check_disk_size_change, it will cause
>>> any capacity change of a gendisk to be propagated to the blockdev
>>> inode. So use that instead of mucking about with locks and
>>> i_size_write.
>>>
>>> Also add a call to revalidate_disk in do_md_run and a few other places
>>> where the gendisk capacity is changed.
>>>
>> This patch causes my Fedora 11 system with all filesystems on RAID-1 to
>> not boot (it hangs in early userspace, Ctrl-Alt-Del reboots the system.)
>
> I reported similar findings, with some more detail, relative to
> Fedora's rawhide here:
> http://lkml.org/lkml/2009/8/5/275
Sounds to be the same, yes.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-08-06 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 21:58 [md PATCH 0/8] Assort md updates for 2.6.31 NeilBrown
2009-08-02 21:58 ` [md PATCH 7/8] md: allow raid5_quiesce to work properly when reshape is happening NeilBrown
2009-08-02 21:58 ` [md PATCH 1/8] md/raid6: release spare page at ->stop() NeilBrown
2009-08-02 21:58 ` [md PATCH 5/8] md: Handle growth of v1.x metadata correctly NeilBrown
2009-08-02 21:58 ` [md PATCH 3/8] md: when a level change reduces the number of devices, remove the excess NeilBrown
2009-08-02 21:58 ` [md PATCH 4/8] md: avoid array overflow with bad v1.x metadata NeilBrown
2009-08-02 21:58 ` [md PATCH 2/8] md: Push down data integrity code to personalities NeilBrown
2009-08-02 21:58 ` [md PATCH 6/8] md/raid5: set reshape_position correctly when reshape starts NeilBrown
2009-08-02 21:58 ` [md PATCH 8/8] md: Use revalidate_disk to effect changes in size of device NeilBrown
2009-08-05 22:07 ` H. Peter Anvin
2009-08-06 1:03 ` Mike Snitzer
2009-08-06 1:15 ` H. Peter Anvin [this message]
2009-08-06 3:13 ` Neil Brown
2009-08-06 4:35 ` H. Peter Anvin
2009-08-07 13:57 ` Mike Snitzer
2009-08-10 1:26 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7A2EA6.9020603@zytor.com \
--to=hpa@zytor.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=snitzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).