From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [md PATCH 8/8] md: Use revalidate_disk to effect changes in size of device. Date: Wed, 05 Aug 2009 18:15:18 -0700 Message-ID: <4A7A2EA6.9020603@zytor.com> References: <20090802215444.4198.83094.stgit@notabene.brown> <20090802215818.4198.77041.stgit@notabene.brown> <4A7A0287.5010505@zytor.com> <170fa0d20908051803ud6ef819xdad3cafe44cc1fb8@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <170fa0d20908051803ud6ef819xdad3cafe44cc1fb8@mail.gmail.com> Sender: linux-raid-owner@vger.kernel.org To: Mike Snitzer Cc: NeilBrown , linux-raid@vger.kernel.org List-Id: linux-raid.ids On 08/05/2009 06:03 PM, Mike Snitzer wrote: > On Wed, Aug 5, 2009 at 6:07 PM, H. Peter Anvin wrote: >> On 08/02/2009 02:58 PM, NeilBrown wrote: >>> As revalidate_disk calls check_disk_size_change, it will cause >>> any capacity change of a gendisk to be propagated to the blockdev >>> inode. So use that instead of mucking about with locks and >>> i_size_write. >>> >>> Also add a call to revalidate_disk in do_md_run and a few other places >>> where the gendisk capacity is changed. >>> >> This patch causes my Fedora 11 system with all filesystems on RAID-1 to >> not boot (it hangs in early userspace, Ctrl-Alt-Del reboots the system.) > > I reported similar findings, with some more detail, relative to > Fedora's rawhide here: > http://lkml.org/lkml/2009/8/5/275 Sounds to be the same, yes. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.